mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2024-12-14 11:57:48 +00:00
Code Activity

chore: enable more linters (#3862)

Browse source 
* chore: enable deadcode and unused linters

Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>

* chore: enable more linters

Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
This commit is contained in:
Charles-Edouard Brétéché 2022-05-10 17:50:04 +02:00 committed by GitHub
parent d982ef77b3
commit bfc4290285
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
.golangci.yml
View file

@ -1,18 +1,20 @@
linters: linters:
enable: enable:
- bodyclose
- deadcode - deadcode
- errcheck - errcheck
- gosec - gosec
- gosimple - gosimple
- bodyclose - govet
- staticcheck
- unused
disable:
- ineffassign - ineffassign
- staticcheck
- structcheck - structcheck
- typecheck
- unused
- varcheck
run: run:
timeout: 5m timeout: 5m
skip-files: skip-files:
- ".+_test.go" - ".+_test.go"
- ".+_test_.+.go" - ".+_test_.+.go"

11
cmd/initContainer/main.go
View file

@ -107,13 +107,13 @@ func main() {
} }
requests := []request{ requests := []request{
{policyReportKind, ""}, {policyReportKind},
{clusterPolicyReportKind, ""}, {clusterPolicyReportKind},
{reportChangeRequestKind, ""}, {reportChangeRequestKind},
{clusterReportChangeRequestKind, ""}, {clusterReportChangeRequestKind},
{convertGenerateRequest, ""}, {convertGenerateRequest},
} }
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
@ -253,7 +253,6 @@ func executeRequest(client client.Interface, kyvernoclient kyvernoclient.Interfa
type request struct { type request struct {
kind string kind string
name string
} }
/* Processing Pipeline /* Processing Pipeline

1
pkg/autogen/autogen.go
View file

@ -199,7 +199,6 @@ func GenerateRulePatches(spec *kyverno.Spec, controllers string) (rulePatches []
rulePatches = append(rulePatches, pbytes) rulePatches = append(rulePatches, pbytes)
} }
insertIdx++ insertIdx++
patchPostion = insertIdx
} }
} }
return return

2
pkg/tls/certRenewer.go
View file

@ -405,7 +405,7 @@ func GenerateRootCASecretName(props *CertificateProps) string {
} }
func CanAddAnnotationToSecret(deplHash string, secret *v1.Secret) bool { func CanAddAnnotationToSecret(deplHash string, secret *v1.Secret) bool {
var deplHashSec string = "default" var deplHashSec string
var ok, managedByKyverno bool var ok, managedByKyverno bool
if label, ok := secret.GetLabels()[ManagedByLabel]; ok { if label, ok := secret.GetLabels()[ManagedByLabel]; ok {

4
pkg/tls/reader.go
View file

@ -29,7 +29,7 @@ func ReadRootCASecret(restConfig *rest.Config, client kubernetes.Interface) (res
deplHash = fmt.Sprintf("%v", depl.GetUID()) deplHash = fmt.Sprintf("%v", depl.GetUID())
} }
var deplHashSec string = "default" var deplHashSec string
var ok, managedByKyverno bool var ok, managedByKyverno bool
sname := GenerateRootCASecretName(certProps) sname := GenerateRootCASecretName(certProps)
@ -68,7 +68,7 @@ func ReadTLSPair(restConfig *rest.Config, client kubernetes.Interface) (*PemPair
deplHash = fmt.Sprintf("%v", depl.GetUID()) deplHash = fmt.Sprintf("%v", depl.GetUID())
} }
var deplHashSec string = "default" var deplHashSec string
var ok, managedByKyverno bool var ok, managedByKyverno bool
sname := GenerateTLSPairSecretName(certProps) sname := GenerateTLSPairSecretName(certProps)