mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

fixes

Browse source
This commit is contained in:
shivkumar dudhani 2019-08-19 11:52:48 -07:00
parent 856d3310d4
commit 9cfdf45bbc
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/api/kyverno/v1alpha1/types.go
View file

@ -47,7 +47,7 @@ type ExcludeResources struct {
type ResourceDescription struct { type ResourceDescription struct {
Kinds []string `json:"kinds"` Kinds []string `json:"kinds"`
Name string `json:"name"` Name string `json:"name"`
Namespaces []string `json:"namespace,omitempty"` Namespaces []string `json:"namespaces,omitempty"`
Selector *metav1.LabelSelector `json:"selector"` Selector *metav1.LabelSelector `json:"selector"`
} }

1
pkg/policy/existing.go
View file

@ -66,6 +66,7 @@ func listResources(client *client.Client, policy kyverno.Policy, filterK8Resourc
} }
if len(rule.MatchResources.Namespaces) > 0 { if len(rule.MatchResources.Namespaces) > 0 {
namespaces = append(namespaces, rule.MatchResources.Namespaces...) namespaces = append(namespaces, rule.MatchResources.Namespaces...)
glog.V(4).Infof("namespaces specified for inclusion: %v", rule.MatchResources.Namespaces)
} else { } else {
glog.V(4).Infof("processing policy %s rule %s, namespace not defined, getting all namespaces ", policy.Name, rule.Name) glog.V(4).Infof("processing policy %s rule %s, namespace not defined, getting all namespaces ", policy.Name, rule.Name)
// get all namespaces // get all namespaces

3
pkg/policyviolation/controller.go
View file

@ -212,6 +212,7 @@ func (pvc *PolicyViolationController) syncPolicyViolation(key string) error {
pv := policyViolation.DeepCopy() pv := policyViolation.DeepCopy()
// TODO: Update Status to update ObserverdGeneration // TODO: Update Status to update ObserverdGeneration
// TODO: check if the policy violation refers to a resource thats active ? // done by policy controller // TODO: check if the policy violation refers to a resource thats active ? // done by policy controller
// TODO: remove the PV, if the corresponding policy is not present
// TODO: additional check on deleted webhook for a resource, to delete a policy violation it has a policy violation // TODO: additional check on deleted webhook for a resource, to delete a policy violation it has a policy violation
// list the resource with label selectors, but this can be expensive for each delete request of a resource // list the resource with label selectors, but this can be expensive for each delete request of a resource
if err := pvc.syncActiveResource(pv); err != nil { if err := pvc.syncActiveResource(pv); err != nil {
@ -242,6 +243,8 @@ func (pvc *PolicyViolationController) syncActiveResource(curPv *kyverno.PolicyVi
glog.V(4).Infof("error while retrieved resource %s/%s/%s: %v", rspec.Kind, rspec.Namespace, rspec.Name, err) glog.V(4).Infof("error while retrieved resource %s/%s/%s: %v", rspec.Kind, rspec.Namespace, rspec.Name, err)
return err return err
} }
//TODO- if the policy is not present, remove the policy violation
return nil return nil
} }