refactor: optimise and use kuttl TestStep with tests (#5328)

* refactor: use kuttl teststep with tests

Signed-off-by: prateekpandey14 <prateek.pandey@nirmata.com>

* optimize kuttl generate test

Signed-off-by: prateekpandey14 <prateek.pandey@nirmata.com>

Signed-off-by: prateekpandey14 <prateek.pandey@nirmata.com>

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/01-cluster-policy.yaml

@@ -0,0 +1,7 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- manifests.yaml
+- cluster-policy.yaml
+assert:
+- cluster-policy-ready.yaml

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/02-assert.yaml

@@ -1,11 +0,0 @@
-apiVersion: v1
-kind: Secret
-metadata:
-  name: image-secret
-  namespace: prod
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: bootstap-config
-  namespace: prod

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/02-trigger.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+  - ns.yaml
+assert:
+  - resource-assert.yaml

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/cluster-policy-ready.yaml

@@ -1,7 +1,7 @@
 apiVersion: kyverno.io/v1
 kind: ClusterPolicy
 metadata:
-  name: sync-secret-with-multi-clone
+  name: sync-with-multi-clone
 status:
   conditions:
   - reason: Succeeded

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/cluster-policy.yaml

@@ -1,9 +1,9 @@
 apiVersion: kyverno.io/v1
 kind: ClusterPolicy
 metadata:
-  name: sync-secret-with-multi-clone
+  name: sync-with-multi-clone
 spec:
-  generateExistingOnPolicyUpdate: true
+  generateExistingOnPolicyUpdate: false
   rules:
   - name: sync-secret
     match:
@@ -30,25 +30,3 @@ spec:
         selector:
           matchLabels:
             allowedToBeCloned: "true"
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: bootstap-config
-  namespace: default
-  labels:
-    allowedToBeCloned:  "true"
-data:
-  initial_lives: "15"
----
-apiVersion: v1
-kind: Secret
-metadata:
-  name: image-secret
-  namespace: default
-  labels:
-    allowedToBeCloned:  "true"
-type: kubernetes.io/basic-auth
-stringData:
-  username: admin
-  password: t0p-Secret-super

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/manifests.yaml

@@ -0,0 +1,21 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: bootstrap-config
+  namespace: default
+  labels:
+    allowedToBeCloned:  "true"
+data:
+  initial_lives: "15"
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: image-secret
+  namespace: default
+  labels:
+    allowedToBeCloned:  "true"
+type: kubernetes.io/basic-auth
+stringData:
+  username: admin
+  password: t0p-Secret-super

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/ns.yaml

@@ -1,4 +1,4 @@
 apiVersion: v1
 kind: Namespace
 metadata:
-  name: prod
+  name: prod-1

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-create/resource-assert.yaml

@@ -0,0 +1,36 @@
+---
+apiVersion: v1
+data:
+  password: dDBwLVNlY3JldC1zdXBlcg==
+  username: YWRtaW4=
+kind: Secret
+metadata:
+  labels:
+    allowedToBeCloned: "true"
+    app.kubernetes.io/managed-by: kyverno
+    generate.kyverno.io/clone-policy-name: sync-with-multi-clone
+    kyverno.io/generated-by-kind: Namespace
+    kyverno.io/generated-by-name: prod-1
+    kyverno.io/generated-by-namespace: ""
+    policy.kyverno.io/policy-name: sync-with-multi-clone
+    policy.kyverno.io/synchronize: enable
+  name: image-secret
+  namespace: prod-1
+type: kubernetes.io/basic-auth
+---
+apiVersion: v1
+data:
+  initial_lives: "15"
+kind: ConfigMap
+metadata:
+  labels:
+    allowedToBeCloned: "true"
+    app.kubernetes.io/managed-by: kyverno
+    generate.kyverno.io/clone-policy-name: sync-with-multi-clone
+    kyverno.io/generated-by-kind: Namespace
+    kyverno.io/generated-by-name: prod-1
+    kyverno.io/generated-by-namespace: ""
+    policy.kyverno.io/policy-name: sync-with-multi-clone
+    policy.kyverno.io/synchronize: enable
+  name: bootstrap-config
+  namespace: prod-1

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-update/cluster-policy-ready.yaml

@@ -1,9 +1,9 @@
 apiVersion: kyverno.io/v1
 kind: ClusterPolicy
 metadata:
-  name: sync-secret-with-multi-clone
+  name: sync-with-multi-clone-update
 status:
   conditions:
   - reason: Succeeded
     status: "True"
-    type: Ready
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-update/cluster-policy.yaml

@@ -1,9 +1,9 @@
 apiVersion: kyverno.io/v1
 kind: ClusterPolicy
 metadata:
-  name: sync-secret-with-multi-clone
+  name: sync-with-multi-clone-update
 spec:
-  generateExistingOnPolicyUpdate: true
+  generateExistingOnPolicyUpdate: false
   rules:
   - name: sync-secret
     match:
@@ -29,4 +29,4 @@ spec:
           - v1/ConfigMap
         selector:
           matchLabels:
-            allowedToBeCloned: "true"
+            allowedToBeCloned: "true"

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-update/resource-assert.yaml

@@ -8,12 +8,11 @@ metadata:
   labels:
     allowedToBeCloned: "true"
     app.kubernetes.io/managed-by: kyverno
-    generate.kyverno.io/clone-policy-name: sync-secret-with-multi-clone
+    generate.kyverno.io/clone-policy-name: sync-with-multi-clone-update
-    kyverno.io/background-gen-rule: sync-secret
     kyverno.io/generated-by-kind: Namespace
     kyverno.io/generated-by-name: prod
     kyverno.io/generated-by-namespace: ""
-    policy.kyverno.io/policy-name: sync-secret-with-multi-clone
+    policy.kyverno.io/policy-name: sync-with-multi-clone-update
     policy.kyverno.io/synchronize: enable
   name: image-secret
   namespace: prod
@@ -27,12 +26,11 @@ metadata:
   labels:
     allowedToBeCloned: "true"
     app.kubernetes.io/managed-by: kyverno
-    generate.kyverno.io/clone-policy-name: sync-secret-with-multi-clone
+    generate.kyverno.io/clone-policy-name: sync-with-multi-clone-update
-    kyverno.io/background-gen-rule: sync-secret
     kyverno.io/generated-by-kind: Namespace
     kyverno.io/generated-by-name: prod
     kyverno.io/generated-by-namespace: ""
-    policy.kyverno.io/policy-name: sync-secret-with-multi-clone
+    policy.kyverno.io/policy-name: sync-with-multi-clone-update
     policy.kyverno.io/synchronize: enable
   name: bootstrap-config
   namespace: prod

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-list-sync-update/synchronized-target.yaml

@@ -7,12 +7,11 @@ metadata:
   labels:
     allowedToBeCloned: "true"
     app.kubernetes.io/managed-by: kyverno
-    generate.kyverno.io/clone-policy-name: sync-secret-with-multi-clone
+    generate.kyverno.io/clone-policy-name: sync-with-multi-clone-update
-    kyverno.io/background-gen-rule: sync-secret
     kyverno.io/generated-by-kind: Namespace
     kyverno.io/generated-by-name: prod
     kyverno.io/generated-by-namespace: ""
-    policy.kyverno.io/policy-name: sync-secret-with-multi-clone
+    policy.kyverno.io/policy-name: sync-with-multi-clone-update
     policy.kyverno.io/synchronize: enable
   name: bootstrap-config
   namespace: prod

test/conformance/kuttl/generate/clusterpolicy/standard/data/sync/cpol-data-sync-create/01-manifests.yaml

@@ -3,7 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: zk-kafka-address
 spec:
-  generateExistingOnPolicyUpdate: true
+  generateExistingOnPolicyUpdate: false
   rules:
   - name: k-kafka-address
     match:
@@ -32,4 +32,4 @@ spec:
             somekey: somevalue
         data:
           ZK_ADDRESS: "192.168.10.10:2181,192.168.10.11:2181,192.168.10.12:2181"
-          KAFKA_ADDRESS: "192.168.10.13:9092,192.168.10.14:9092,192.168.10.15:9092"
+          KAFKA_ADDRESS: "192.168.10.13:9092,192.168.10.14:9092,192.168.10.15:9092"

test/conformance/kuttl/generate/clusterpolicy/standard/data/sync/cpol-data-sync-delete-policy/01-manifests.yaml

@@ -3,7 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: zk-kafka-address
 spec:
-  generateExistingOnPolicyUpdate: true
+  generateExistingOnPolicyUpdate: false
   rules:
   - name: k-kafka-address
     match:
@@ -32,4 +32,4 @@ spec:
             somekey: somevalue
         data:
           ZK_ADDRESS: "192.168.10.10:2181,192.168.10.11:2181,192.168.10.12:2181"
-          KAFKA_ADDRESS: "192.168.10.13:9092,192.168.10.14:9092,192.168.10.15:9092"
+          KAFKA_ADDRESS: "192.168.10.13:9092,192.168.10.14:9092,192.168.10.15:9092"