From 987489d800cd706e189be1e9bad5d18f856aecb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Charles-Edouard=20Br=C3=A9t=C3=A9ch=C3=A9?= Date: Wed, 30 Nov 2022 12:53:30 +0100 Subject: [PATCH] chore: stop using set-output in gh actions (#5500) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore: stop using set-output in gh actions Signed-off-by: Charles-Edouard Brétéché * add quotes Signed-off-by: Charles-Edouard Brétéché * add quotes Signed-off-by: Charles-Edouard Brétéché Signed-off-by: Charles-Edouard Brétéché Co-authored-by: Vyankatesh Kudtarkar --- .github/workflows/release.yaml | 6 +++--- .github/workflows/report-on-vulnerabilities.yaml | 6 +++--- .github/workflows/reuse.yaml | 12 ++++++------ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 1c39b39f88..4de9e99aec 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -59,7 +59,7 @@ jobs: steps: - name: Set version id: version - run: echo ::set-output name=version::${GITHUB_REF#refs/*/} + run: echo "version=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT - name: Checkout uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # pin@v2.4.0 @@ -112,7 +112,7 @@ jobs: steps: - name: Set version id: version - run: echo ::set-output name=version::${GITHUB_REF#refs/*/} + run: echo "version=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT - name: Checkout uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # pin@v2.4.0 @@ -186,7 +186,7 @@ jobs: id: check-tag run: | if [[ ${{ github.event.ref }} =~ ^refs/tags/v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo ::set-output name=match::true + echo "match=true" >> $GITHUB_OUTPUT fi - name: Update new version in krew-index diff --git a/.github/workflows/report-on-vulnerabilities.yaml b/.github/workflows/report-on-vulnerabilities.yaml index 310d9ddfc9..f3ffd2497a 100644 --- a/.github/workflows/report-on-vulnerabilities.yaml +++ b/.github/workflows/report-on-vulnerabilities.yaml @@ -30,10 +30,10 @@ jobs: VULNS=$(cat scan.json | jq '.Results[] | has("Vulnerabilities")') if echo $VULNS | grep -q 'true'; then echo "Vulnerabilities found, creating issue" - echo ::set-output name=results::$(cat scan.json) + echo "results=$(cat scan.json)" >> $GITHUB_OUTPUT else echo "No vulnerabilities found, halting" - echo ::set-output name=results::$(echo nothing) + echo "results=nothing" >> $GITHUB_OUTPUT fi - name: Upload vulnerability scan report @@ -58,7 +58,7 @@ jobs: - name: Set scan output id: set-scan-output - run: echo ::set-output name=results::$(cat scan.json) + run: echo "results=$(cat scan.json)" >> $GITHUB_OUTPUT - uses: JasonEtco/create-an-issue@1a16035489d05041b9af40b970f02e301c52ffba # v2.8.0 env: diff --git a/.github/workflows/reuse.yaml b/.github/workflows/reuse.yaml index 88dc11cb64..2bdd97eb7d 100644 --- a/.github/workflows/reuse.yaml +++ b/.github/workflows/reuse.yaml @@ -117,7 +117,7 @@ jobs: id: check-branch run: | if [[ ${{ steps.extract_branch.outputs.branch }} =~ ^release-[0-9]+\.[0-9]$ ]]; then - echo ::set-output name=match::true + echo "match=true" >> $GITHUB_OUTPUT fi - name: ko build dev image @@ -127,7 +127,7 @@ jobs: if: ${{inputs.tag == 'image' && steps.extract_branch.outputs.branch == 'main'}} run: | set -e - echo "::set-output name=digest::$(REGISTRY=ghcr.io REPO=${{ github.repository_owner }} REGISTRY_PASSWORD=${{secrets.registry_password}} make ${{inputs.publish_command}}-dev)" + echo "digest=$(REGISTRY=ghcr.io REPO=${{ github.repository_owner }} REGISTRY_PASSWORD=${{secrets.registry_password}} make ${{inputs.publish_command}}-dev)" >> $GITHUB_OUTPUT - name: ko build release image id: ko-publish @@ -136,7 +136,7 @@ jobs: if: ${{inputs.tag == 'release' || (inputs.tag == 'image' && steps.check-branch.outputs.match == 'true')}} run: | set -e - echo "::set-output name=digest::$(REGISTRY=ghcr.io REPO=${{ github.repository_owner }} REGISTRY_PASSWORD=${{secrets.registry_password}} make ${{inputs.publish_command}})" + echo "digest=$(REGISTRY=ghcr.io REPO=${{ github.repository_owner }} REGISTRY_PASSWORD=${{secrets.registry_password}} make ${{inputs.publish_command}})" >> $GITHUB_OUTPUT - name: Sign dev image if: ${{inputs.tag == 'image' && steps.extract_branch.outputs.branch == 'main'}} @@ -178,9 +178,9 @@ jobs: DIGEST=$(echo ${{ steps.ko-publish.outputs.digest }} | cut -d '@' -f2) echo "Digest from image is: $DIGEST" if [[ "${{inputs.publish_command}}" = "ko-publish-kyvernopre" ]]; then - echo "::set-output name=init-container-digest::$DIGEST" + echo "init-container-digest=$DIGEST" >> $GITHUB_OUTPUT elif [[ "${{inputs.publish_command}}" = "ko-publish-kyverno" ]]; then - echo "::set-output name=kyverno-digest::$DIGEST" + echo "kyverno-digest=$DIGEST" >> $GITHUB_OUTPUT else - echo "::set-output name=cli-digest::$DIGEST" + echo "name=cli-digest=$DIGEST" >> $GITHUB_OUTPUT fi