From 8c2335fe5554606fafb218b5346d3c96b17003b1 Mon Sep 17 00:00:00 2001 From: Mariam Fahmy Date: Thu, 13 Jul 2023 11:54:08 +0300 Subject: [PATCH] fix: skip creating event for an empty resource name (#7810) Signed-off-by: Mariam Fahmy --- pkg/event/events.go | 7 +++++-- pkg/webhooks/utils/event.go | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/event/events.go b/pkg/event/events.go index 247c17cedf..ae6426d232 100644 --- a/pkg/event/events.go +++ b/pkg/event/events.go @@ -60,9 +60,12 @@ func NewPolicyAppliedEvent(source Source, engineResponse engineapi.EngineRespons } hasValidate := engineResponse.Policy().GetSpec().HasValidate() - if hasValidate { + hasVerifyImages := engineResponse.Policy().GetSpec().HasVerifyImages() + hasMutate := engineResponse.Policy().GetSpec().HasMutate() + + if hasValidate || hasVerifyImages { fmt.Fprintf(&bldr, "%s: pass", res) - } else { + } else if hasMutate { fmt.Fprintf(&bldr, "%s is successfully mutated", res) } diff --git a/pkg/webhooks/utils/event.go b/pkg/webhooks/utils/event.go index f4522397dd..9aba42bf78 100644 --- a/pkg/webhooks/utils/event.go +++ b/pkg/webhooks/utils/event.go @@ -16,7 +16,7 @@ func GenerateEvents(engineResponses []engineapi.EngineResponse, blocked bool) [] // - Some/All policies skipped // - report skipped event on resource for _, er := range engineResponses { - if er.IsEmpty() { + if er.IsEmpty() || er.Resource.GetName() == "" { continue } if !er.IsSuccessful() {