mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-04-08 10:04:25 +00:00
Code Activity

update tests

Browse source
This commit is contained in:
shivkumar dudhani 2019-12-12 10:47:25 -08:00
parent 7c9bc6fecf
commit 8b1e084691
2 changed files with 70 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/engine/variables/variables.go
View file

@ -8,6 +8,11 @@ import (
"github.com/nirmata/kyverno/pkg/engine/operator"
)
//SubstituteVariables substitutes the JMESPATH with variable substitution
// supported substitutions
// - no operator + variable(string,object)
// unsupported substitutions
// - operator + variable(object) -> as we dont support operators with object types
func SubstituteVariables(ctx context.EvalInterface, pattern interface{}) interface{} {
// var err error
switch typedPattern := pattern.(type) {
@ -16,7 +21,7 @@ func SubstituteVariables(ctx context.EvalInterface, pattern interface{}) interfa
case []interface{}:
return substituteArray(ctx, typedPattern)
case string:
// variable substitution is for strings
// variable substitution
return substituteValue(ctx, typedPattern)
default:
return pattern
@ -38,6 +43,7 @@ func substituteArray(ctx context.EvalInterface, patternList []interface{}) []int
}
return patternList
}
func substituteValue(ctx context.EvalInterface, valuePattern string) interface{} {
// patterns supported
// - operator + string
@ -57,7 +63,7 @@ func substituteValue(ctx context.EvalInterface, valuePattern string) interface{}
case string:
return string(operatorVariable) + value.(string)
default:
glog.V(4).Info("cannot user operator with object variables")
glog.Infof("cannot user operator with object variables. operator used %s in pattern %v", string(operatorVariable), valuePattern)
var emptyInterface interface{}
return emptyInterface
}

74
pkg/engine/variables/variables_test.go
View file

@ -2,6 +2,7 @@ package variables
import (
"encoding/json"
"reflect"
"testing"
"github.com/nirmata/kyverno/pkg/engine/context"
@ -29,6 +30,8 @@ func Test_variableSubstitutionValue(t *testing.T) {
}
`)
resultMap := []byte(`{"spec":{"name":"temp"}}`)
var pattern, resource interface{}
json.Unmarshal(patternMap, &pattern)
json.Unmarshal(resourceRaw, &resource)
@ -37,8 +40,13 @@ func Test_variableSubstitutionValue(t *testing.T) {
ctx := context.NewContext()
ctx.Add("resource", resourceRaw)
value := SubstituteVariables(ctx, pattern)
t.Log(value)
t.Fail()
resultRaw, err := json.Marshal(value)
if err != nil {
t.Error(err)
}
if !reflect.DeepEqual(resultMap, resultRaw) {
t.Error("result does not match")
}
}
func Test_variableSubstitutionValueOperatorNotEqual(t *testing.T) {
@ -62,6 +70,7 @@ func Test_variableSubstitutionValueOperatorNotEqual(t *testing.T) {
}
}
`)
resultMap := []byte(`{"spec":{"name":"!temp"}}`)
var pattern, resource interface{}
json.Unmarshal(patternMap, &pattern)
@ -71,8 +80,15 @@ func Test_variableSubstitutionValueOperatorNotEqual(t *testing.T) {
ctx := context.NewContext()
ctx.Add("resource", resourceRaw)
value := SubstituteVariables(ctx, pattern)
t.Log(value)
t.Fail()
resultRaw, err := json.Marshal(value)
if err != nil {
t.Error(err)
}
t.Log(string(resultRaw))
t.Log(string(resultMap))
if !reflect.DeepEqual(resultMap, resultRaw) {
t.Error("result does not match")
}
}
func Test_variableSubstitutionValueFail(t *testing.T) {
@ -96,6 +112,7 @@ func Test_variableSubstitutionValueFail(t *testing.T) {
}
}
`)
resultMap := []byte(`{"spec":{"name":null}}`)
var pattern, resource interface{}
json.Unmarshal(patternMap, &pattern)
@ -105,8 +122,15 @@ func Test_variableSubstitutionValueFail(t *testing.T) {
ctx := context.NewContext()
ctx.Add("resource", resourceRaw)
value := SubstituteVariables(ctx, pattern)
t.Log(value)
t.Fail()
resultRaw, err := json.Marshal(value)
if err != nil {
t.Error(err)
}
t.Log(string(resultRaw))
t.Log(string(resultMap))
if !reflect.DeepEqual(resultMap, resultRaw) {
t.Error("result does not match")
}
}
func Test_variableSubstitutionObject(t *testing.T) {
@ -135,6 +159,7 @@ func Test_variableSubstitutionObject(t *testing.T) {
}
}
`)
resultMap := []byte(`{"spec":{"variable":{"var1":"temp1","var2":"temp2","varNested":{"var1":"temp1"}}}}`)
var pattern, resource interface{}
json.Unmarshal(patternMap, &pattern)
@ -144,8 +169,15 @@ func Test_variableSubstitutionObject(t *testing.T) {
ctx := context.NewContext()
ctx.Add("resource", resourceRaw)
value := SubstituteVariables(ctx, pattern)
t.Log(value)
t.Fail()
resultRaw, err := json.Marshal(value)
if err != nil {
t.Error(err)
}
t.Log(string(resultRaw))
t.Log(string(resultMap))
if !reflect.DeepEqual(resultMap, resultRaw) {
t.Error("result does not match")
}
}
func Test_variableSubstitutionObjectOperatorNotEqualFail(t *testing.T) {
@ -175,6 +207,8 @@ func Test_variableSubstitutionObjectOperatorNotEqualFail(t *testing.T) {
}
`)
resultMap := []byte(`{"spec":{"variable":null}}`)
var pattern, resource interface{}
json.Unmarshal(patternMap, &pattern)
json.Unmarshal(resourceRaw, &resource)
@ -183,8 +217,15 @@ func Test_variableSubstitutionObjectOperatorNotEqualFail(t *testing.T) {
ctx := context.NewContext()
ctx.Add("resource", resourceRaw)
value := SubstituteVariables(ctx, pattern)
t.Log(value)
t.Fail()
resultRaw, err := json.Marshal(value)
if err != nil {
t.Error(err)
}
t.Log(string(resultRaw))
t.Log(string(resultMap))
if !reflect.DeepEqual(resultMap, resultRaw) {
t.Error("result does not match")
}
}
func Test_variableSubstitutionMultipleObject(t *testing.T) {
@ -215,6 +256,8 @@ func Test_variableSubstitutionMultipleObject(t *testing.T) {
}
`)
resultMap := []byte(`{"spec":{"var":"temp1","variable":{"var1":"temp1","var2":"temp2","varNested":{"var1":"temp1"}}}}`)
var pattern, resource interface{}
json.Unmarshal(patternMap, &pattern)
json.Unmarshal(resourceRaw, &resource)
@ -223,6 +266,13 @@ func Test_variableSubstitutionMultipleObject(t *testing.T) {
ctx := context.NewContext()
ctx.Add("resource", resourceRaw)
value := SubstituteVariables(ctx, pattern)
t.Log(value)
t.Fail()
resultRaw, err := json.Marshal(value)
if err != nil {
t.Error(err)
}
t.Log(string(resultRaw))
t.Log(string(resultMap))
if !reflect.DeepEqual(resultMap, resultRaw) {
t.Error("result does not match")
}
}