mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

Feature/make operators case insensitive (#1217)

Browse source 
* fix typo

* make operators case insensitive

* fix case statement
This commit is contained in:
Jim Bugwadia 2020-10-29 15:00:22 -07:00 • committed by GitHub
parent ee6ff959de
commit 7e9b08baeb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
pkg/engine/variables/operator/operator.go
View file

@ -4,6 +4,7 @@ import (
"github.com/go-logr/logr"
kyverno "github.com/kyverno/kyverno/pkg/api/kyverno/v1"
"github.com/kyverno/kyverno/pkg/engine/context"
"strings"
)
//OperatorHandler provides interface to manage types
@ -21,21 +22,30 @@ type VariableSubstitutionHandler = func(log logr.Logger, ctx context.EvalInterfa
//CreateOperatorHandler returns the operator handler based on the operator used in condition
func CreateOperatorHandler(log logr.Logger, ctx context.EvalInterface, op kyverno.ConditionOperator, subHandler VariableSubstitutionHandler) OperatorHandler {
switch op {
case kyverno.Equal:
str := strings.ToLower(string(op))
switch str {
case strings.ToLower(string(kyverno.Equal)):
return NewEqualHandler(log, ctx, subHandler)
case kyverno.NotEqual:
return NewNotEqualHandler(log, ctx, subHandler)
case kyverno.Equals:
case strings.ToLower(string(kyverno.Equals)):
return NewEqualHandler(log, ctx, subHandler)
case kyverno.NotEquals:
case strings.ToLower(string(kyverno.NotEqual)):
return NewNotEqualHandler(log, ctx, subHandler)
case kyverno.In:
case strings.ToLower(string(kyverno.NotEquals)):
return NewNotEqualHandler(log, ctx, subHandler)
case strings.ToLower(string(kyverno.In)):
return NewInHandler(log, ctx, subHandler)
case kyverno.NotIn:
case strings.ToLower(string(kyverno.NotIn)):
return NewNotInHandler(log, ctx, subHandler)
default:
log.Info("operator not supported", "operator", string(op))
log.Info("operator not supported", "operator", str)
}
return nil
}

2
pkg/webhooks/policyvalidation.go
View file

@ -20,7 +20,7 @@ func (ws *WebhookServer) policyValidation(request *v1beta1.AdmissionRequest) *v1
//TODO: can this happen? wont this be picked by OpenAPI spec schema ?
if err := policyvalidate.Validate(request.Object.Raw, ws.client, false, ws.openAPIController); err != nil {
logger.Error(err, "faield to validate policy")
logger.Error(err, "failed to validate policy")
return &v1beta1.AdmissionResponse{
Allowed: false,
Result: &metav1.Status{