From 7d423f97c4a6caaf554b6acdf4206ad391051a99 Mon Sep 17 00:00:00 2001 From: Anushka Mittal <55237170+anushkamittal20@users.noreply.github.com> Date: Thu, 11 Nov 2021 22:27:18 +0530 Subject: [PATCH] added check for misspelled fields in condition (#2707) * added check for misspelled fields in condition Signed-off-by: anushkamittal20 * corrections in error message Signed-off-by: anushkamittal20 --- pkg/policy/validate.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/policy/validate.go b/pkg/policy/validate.go index 18843dfd94..7ffc184752 100644 --- a/pkg/policy/validate.go +++ b/pkg/policy/validate.go @@ -997,6 +997,9 @@ func validateConditions(conditions apiextensions.JSON, schemaKey string) (string // validateConditionValues validates whether all the values under the 'value' field of a 'conditions' field // are apt with respect to the provided 'condition.key' func validateConditionValues(c kyverno.Condition) (string, error) { + if c.Key == nil || c.Value == nil || c.Operator == "" { + return "", fmt.Errorf("entered value of `key`, `value` or `operator` is missing or misspelled") + } switch strings.ReplaceAll(c.Key.(string), " ", "") { case "{{request.operation}}": return validateConditionValuesKeyRequestOperation(c)