mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

[Feat]: added ttl-metrics (#8096)

Browse source 
* added ttl-metrics

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

* lint

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

* applied changes

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

* added gvr in labels

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

* fix

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

* lint fix

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

---------

Signed-off-by: Ved Ratan <vedratan8@gmail.com>
This commit is contained in:
Ved Ratan 2023-08-24 14:02:46 +05:30 • committed by GitHub
parent 3c09d902fd
commit 780f1c1e09
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 50 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
pkg/controllers/ttl/controller.go
View file

@ -6,9 +6,14 @@ import (
"github.com/go-logr/logr"
"github.com/kyverno/kyverno/api/kyverno"
"github.com/kyverno/kyverno/pkg/metrics"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/informers"
"k8s.io/client-go/metadata"
@ -24,9 +29,16 @@ type controller struct {
informer cache.SharedIndexInformer
registration cache.ResourceEventHandlerRegistration
logger logr.Logger
metrics ttlMetrics
gvr schema.GroupVersionResource
}
func newController(client metadata.Getter, metainformer informers.GenericInformer, logger logr.Logger) (*controller, error) {
type ttlMetrics struct {
deletedObjectsTotal metric.Int64Counter
ttlFailureTotal metric.Int64Counter
}
func newController(client metadata.Getter, metainformer informers.GenericInformer, logger logr.Logger, gvr schema.GroupVersionResource) (*controller, error) {
c := &controller{
client: client,
queue: workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()),
@ -34,6 +46,7 @@ func newController(client metadata.Getter, metainformer informers.GenericInforme
wg: wait.Group{},
informer: metainformer.Informer(),
logger: logger,
metrics: newTTLMetrics(logger),
}
registration, err := c.informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: c.handleAdd,
@ -47,6 +60,28 @@ func newController(client metadata.Getter, metainformer informers.GenericInforme
return c, nil
}
func newTTLMetrics(logger logr.Logger) ttlMetrics {
meter := otel.GetMeterProvider().Meter(metrics.MeterName)
deletedObjectsTotal, err := meter.Int64Counter(
"kyverno_ttl_controller_deletedobjects",
metric.WithDescription("can be used to track number of deleted objects by the ttl resource controller."),
)
if err != nil {
logger.Error(err, "Failed to create instrument, ttl_controller_deletedobjects_total")
}
ttlFailureTotal, err := meter.Int64Counter(
"kyverno_ttl_controller_errors",
metric.WithDescription("can be used to track number of ttl cleanup failures."),
)
if err != nil {
logger.Error(err, "Failed to create instrument, ttl_controller_errors_total")
}
return ttlMetrics{
deletedObjectsTotal: deletedObjectsTotal,
ttlFailureTotal: ttlFailureTotal,
}
}
func (c *controller) handleAdd(obj interface{}) {
c.enqueue(obj)
}
@ -147,6 +182,13 @@ func (c *controller) reconcile(itemKey string) error {
return err
}
commonLabels := []attribute.KeyValue{
attribute.String("resource_namespace", metaObj.GetNamespace()),
attribute.String("resource_group", c.gvr.Group),
attribute.String("resource_version", c.gvr.Version),
attribute.String("resource", c.gvr.Resource),
}
// if the object is being deleted, return early
if metaObj.GetDeletionTimestamp() != nil {
return nil
@ -174,10 +216,16 @@ func (c *controller) reconcile(itemKey string) error {
err = c.client.Namespace(namespace).Delete(context.Background(), metaObj.GetName(), metav1.DeleteOptions{})
if err != nil {
logger.Error(err, "failed to delete resource")
if c.metrics.ttlFailureTotal != nil {
c.metrics.ttlFailureTotal.Add(context.Background(), 1, metric.WithAttributes(commonLabels...))
}
return err
}
logger.Info("resource has been deleted")
} else {
if c.metrics.deletedObjectsTotal != nil {
c.metrics.deletedObjectsTotal.Add(context.Background(), 1, metric.WithAttributes(commonLabels...))
}
// Calculate the remaining time until deletion
timeRemaining := time.Until(deletionTime)
// Add the item back to the queue after the remaining time

2
pkg/controllers/ttl/manager.go
View file

@ -143,7 +143,7 @@ func (m *manager) start(ctx context.Context, gvr schema.GroupVersionResource, wo
stopInformer()
return fmt.Errorf("failed to wait for cache sync: %s", gvr.Resource)
}
controller, err := newController(m.metadataClient.Resource(gvr), informer, logger)
controller, err := newController(m.metadataClient.Resource(gvr), informer, logger, gvr)
if err != nil {
stopInformer()
return err