mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

fix: histogram buckets (#6783)

Browse source 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
This commit is contained in:
Charles-Edouard Brétéché 2023-04-05 11:58:07 +02:00 • committed by GitHub
parent b9da54e561
commit 6f8ef4fd30
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
pkg/metrics/metrics.go
View file

@ -18,6 +18,7 @@ import (
"go.opentelemetry.io/otel/metric" "go.opentelemetry.io/otel/metric"
"go.opentelemetry.io/otel/metric/instrument" "go.opentelemetry.io/otel/metric/instrument"
sdkmetric "go.opentelemetry.io/otel/sdk/metric" sdkmetric "go.opentelemetry.io/otel/sdk/metric"
"go.opentelemetry.io/otel/sdk/metric/aggregation"
"go.opentelemetry.io/otel/sdk/resource" "go.opentelemetry.io/otel/sdk/resource"
semconv "go.opentelemetry.io/otel/semconv/v1.17.0" semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
"k8s.io/client-go/kubernetes" "k8s.io/client-go/kubernetes"
@ -72,6 +73,34 @@ func ShutDownController(ctx context.Context, pusher *sdkmetric.MeterProvider) {
} }
} }
func aggregationSelector(ik sdkmetric.InstrumentKind) aggregation.Aggregation {
switch ik {
case sdkmetric.InstrumentKindHistogram:
return aggregation.ExplicitBucketHistogram{
Boundaries: []float64{
0.005,
0.01,
0.025,
0.05,
0.1,
0.25,
0.5,
1,
2.5,
5,
10,
15,
20,
25,
30,
},
NoMinMax: false,
}
default:
return sdkmetric.DefaultAggregationSelector(ik)
}
}
func NewOTLPGRPCConfig( func NewOTLPGRPCConfig(
ctx context.Context, ctx context.Context,
endpoint string, endpoint string,
@ -79,7 +108,7 @@ func NewOTLPGRPCConfig(
kubeClient kubernetes.Interface, kubeClient kubernetes.Interface,
log logr.Logger, log logr.Logger,
) (metric.MeterProvider, error) { ) (metric.MeterProvider, error) {
options := []otlpmetricgrpc.Option{otlpmetricgrpc.WithEndpoint(endpoint)} options := []otlpmetricgrpc.Option{otlpmetricgrpc.WithEndpoint(endpoint), otlpmetricgrpc.WithAggregationSelector(aggregationSelector)}
if certs != "" { if certs != "" {
// here the certificates are stored as configmaps // here the certificates are stored as configmaps
transportCreds, err := kube.FetchCert(ctx, certs, kubeClient) transportCreds, err := kube.FetchCert(ctx, certs, kubeClient)
@ -141,6 +170,7 @@ func NewPrometheusConfig(
exporter, err := prometheus.New( exporter, err := prometheus.New(
prometheus.WithoutUnits(), prometheus.WithoutUnits(),
prometheus.WithoutTargetInfo(), prometheus.WithoutTargetInfo(),
prometheus.WithAggregationSelector(aggregationSelector),
) )
if err != nil { if err != nil {
log.Error(err, "failed to initialize prometheus exporter") log.Error(err, "failed to initialize prometheus exporter")