From a28706731565b2dde5af651081b72a9771f36bd9 Mon Sep 17 00:00:00 2001
From: shivkumar dudhani <shivkumar@nirmata.com>
Date: Tue, 29 Oct 2019 10:56:28 -0700
Subject: [PATCH] add backward support for command line arguments for filtering
 resources

---
 main.go                     |  9 +++++++--
 pkg/config/dynamicconfig.go | 22 ++++++++++++++++++++--
 2 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/main.go b/main.go
index 324de77555..a4855a35da 100644
--- a/main.go
+++ b/main.go
@@ -26,6 +26,9 @@ var (
 	cpu            bool
 	memory         bool
 	webhookTimeout int
+	//TODO: this has been added to backward support command line arguments
+	// will be removed in future and the configuration will be set only via configmaps
+	filterK8Resources string
 )
 
 // TODO: tune resync time differently for each informer
@@ -95,7 +98,7 @@ func main() {
 	// dyamically load the configuration from configMap
 	// - resource filters
 	// if the configMap is update, the configuration will be updated :D
-	configData := config.NewConfigData(kubeClient, kubeInformer.Core().V1().ConfigMaps())
+	configData := config.NewConfigData(kubeClient, kubeInformer.Core().V1().ConfigMaps(), filterK8Resources)
 
 	// EVENT GENERATOR
 	// - generate event with retry mechanism
@@ -178,7 +181,9 @@ func init() {
 	// by default is to profile cpu
 	flag.BoolVar(&cpu, "cpu", false, "cpu profilling feature gate, default to false || cpu and memory profiling cannot be enabled at the same time")
 	flag.BoolVar(&memory, "memory", false, "memory profilling feature gate, default to false || cpu and memory profiling cannot be enabled at the same time")
-
+	//TODO: this has been added to backward support command line arguments
+	// will be removed in future and the configuration will be set only via configmaps
+	flag.StringVar(&filterK8Resources, "filterK8Resources", "", "k8 resource in format [kind,namespace,name] where policy is not evaluated by the admission webhook. example --filterKind \"[Deployment, kyverno, kyverno]\" --filterKind \"[Deployment, kyverno, kyverno],[Events, *, *]\"")
 	flag.IntVar(&webhookTimeout, "webhooktimeout", 2, "timeout for webhook configurations")
 	flag.StringVar(&kubeconfig, "kubeconfig", "", "Path to a kubeconfig. Only required if out-of-cluster.")
 	flag.StringVar(&serverIP, "serverIP", "", "IP address where Kyverno controller runs. Only required if out-of-cluster.")
diff --git a/pkg/config/dynamicconfig.go b/pkg/config/dynamicconfig.go
index 364e9ff399..ce95288a22 100644
--- a/pkg/config/dynamicconfig.go
+++ b/pkg/config/dynamicconfig.go
@@ -49,7 +49,7 @@ type Interface interface {
 }
 
 // NewConfigData ...
-func NewConfigData(rclient kubernetes.Interface, cmInformer informers.ConfigMapInformer) *ConfigData {
+func NewConfigData(rclient kubernetes.Interface, cmInformer informers.ConfigMapInformer, filterK8Resources string) *ConfigData {
 	// environment var is read at start only
 	if cmNameEnv == "" {
 		glog.Info("ConfigMap name not defined in env:INIT_CONFIG: loading no default configuration")
@@ -58,6 +58,12 @@ func NewConfigData(rclient kubernetes.Interface, cmInformer informers.ConfigMapI
 		client: rclient,
 		cmName: os.Getenv(cmNameEnv),
 	}
+	//TODO: this has been added to backward support command line arguments
+	// will be removed in future and the configuration will be set only via configmaps
+	if filterK8Resources != "" {
+		glog.Info("Init configuration from commandline arguments")
+		cd.initFilters(filterK8Resources)
+	}
 
 	cmInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
 		AddFunc:    cd.addCM,
@@ -131,7 +137,6 @@ func (cd *ConfigData) load(cm v1.ConfigMap) {
 		glog.Infof("Configuration: resourceFilters is empty in ConfigMap %s", cm.Name)
 		return
 	}
-
 	// parse and load the configuration
 	cd.mux.Lock()
 	defer cd.mux.Unlock()
@@ -147,6 +152,19 @@ func (cd *ConfigData) load(cm v1.ConfigMap) {
 	cd.filters = newFilters
 }
 
+//TODO: this has been added to backward support command line arguments
+// will be removed in future and the configuration will be set only via configmaps
+func (cd *ConfigData) initFilters(filters string) {
+	// parse and load the configuration
+	cd.mux.Lock()
+	defer cd.mux.Unlock()
+
+	newFilters := parseKinds(filters)
+	glog.Infof("Configuration: Init resource filters to %v", newFilters)
+	// update filters
+	cd.filters = newFilters
+}
+
 func (cd *ConfigData) unload(cm v1.ConfigMap) {
 	// TODO pick one msg
 	glog.Infof("Configuration: ConfigMap %s deleted, removing configuration filters", cm.Name)