Update kuttl test scaffolding (#5303)

* add test instructions

Signed-off-by: Chip Zoller <chipzoller@gmail.com>

* update scaffolding

Signed-off-by: Chip Zoller <chipzoller@gmail.com>

Signed-off-by: Chip Zoller <chipzoller@gmail.com>
Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>

test/conformance/kuttl/aaa_template_resources/BEST_PRACTICES.md

@@ -1,6 +1,6 @@
 # Some Best Practices
 
 * Don't put anything in index `00` so it can be used in the future.
-* Put clean-up as index `99` so it's always last no matter how many steps.
+* A final clean-up stage/file is not needed unless a resource was created using a Script. Use scripts sparingly!
 * The `*-errors.yaml` file, like an `*-assert.yaml` file only performs an existence check, not a creation check.
 * One test can contain both positive and negative tests by extending the test case. No need to write separate.

test/conformance/kuttl/aaa_template_resources/scaffold/01-policy.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- policy.yaml
+assert:
+- policy-ready.yaml

test/conformance/kuttl/aaa_template_resources/scaffold/02-resource.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- resource.yaml
+assert:
+- resource-mutated.yaml

test/conformance/kuttl/aaa_template_resources/scaffold/99-cleanup.yaml

@@ -1,4 +0,0 @@
-apiVersion: kuttl.dev/v1beta1
-kind: TestStep
-commands:
-  - command: kubectl delete -f 01-manifests.yaml --force --wait=true --ignore-not-found=true

test/conformance/kuttl/aaa_template_resources/scaffold/policy-ready.yaml

@@ -6,4 +6,4 @@ status:
   conditions:
   - reason: Succeeded
     status: "True"
-    type: Ready
+    type: Ready

test/conformance/kuttl/aaa_template_resources/scaffold/policy.yaml

@@ -16,4 +16,4 @@ spec:
       patchStrategicMerge:
         metadata:
           labels:
-            foo: bar
+            foo: bar

test/conformance/kuttl/aaa_template_resources/scaffold/resource-mutated.yaml

@@ -0,0 +1,7 @@
+apiVersion: v1
+kind: Secret
+metadata:
+  name: testingsecret
+  namespace: default
+  labels:
+    foo: bar