fix: missing/incorrect env variables (#7383)

* fix: panic if an env variable is missing

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

charts/kyverno/templates/admission-controller/deployment.yaml

@@ -98,6 +98,8 @@ spec:
             {{- toYaml . | nindent 12 }}
           {{- end }}
           env:
+          - name: INIT_CONFIG
+            value: {{ template "kyverno.config.configMapName" . }}
           - name: METRICS_CONFIG
             value: {{ template "kyverno.config.metricsConfigMapName" . }}
           - name: KYVERNO_NAMESPACE
@@ -109,7 +111,9 @@ spec:
               fieldRef:
                 fieldPath: metadata.name
           - name: KYVERNO_DEPLOYMENT
-            value: {{ template "kyverno.fullname" . }}
+            value: {{ template "kyverno.admission-controller.name" . }}
+          - name: KYVERNO_SVC
+            value: {{ template "kyverno.admission-controller.serviceName" . }}
           {{- with .Values.admissionController.initContainer.extraEnvVars }}
           {{- toYaml . | nindent 10 }}
           {{- end }}

config/install-latest-testing.yaml

@@ -37255,6 +37255,8 @@ spec:
             seccompProfile:
               type: RuntimeDefault
           env:
+          - name: INIT_CONFIG
+            value: kyverno
           - name: METRICS_CONFIG
             value: kyverno-metrics
           - name: KYVERNO_NAMESPACE
@@ -37266,7 +37268,9 @@ spec:
               fieldRef:
                 fieldPath: metadata.name
           - name: KYVERNO_DEPLOYMENT
-            value: kyverno
+            value: kyverno-admission-controller
+          - name: KYVERNO_SVC
+            value: kyverno-svc
       containers:
         - name: kyverno
           image: "ghcr.io/kyverno/kyverno:latest"

pkg/utils/os/env.go

@@ -1,6 +1,9 @@
 package os
 
-import "os"
+import (
+	"fmt"
+	"os"
+)
 
 func GetEnvWithFallback(name, fallback string) string {
 	if value := os.Getenv(name); value != "" {
@@ -8,3 +11,10 @@ func GetEnvWithFallback(name, fallback string) string {
 	}
 	return fallback
 }
+
+func MustGetEnv(name string) string {
+	if value := os.Getenv(name); value != "" {
+		return value
+	}
+	panic(fmt.Sprintf("environment variable `%s` is required.", name))
+}