mirror of
https://github.com/kyverno/kyverno.git
synced 2025-03-31 03:45:17 +00:00
add unit tests
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
This commit is contained in:
Shuting Zhao
parent
c4ebef7b0d
commit
517c60fadc
3 changed files with 184 additions and 8 deletions
|
|
@ -72,7 +72,7 @@ func applyPatchesWithOptions(resource, patch []byte) ([]byte, error) {
|
|||
return resource, fmt.Errorf("failed to decode patches: %v", err)
|
||||
}
|
||||
|
||||
options := &jsonpatch.ApplyOptions{AllowMissingPathOnRemove: true, EnsurePathExistsOnAdd: true}
|
||||
options := &jsonpatch.ApplyOptions{SupportNegativeIndices: true, AllowMissingPathOnRemove: true, EnsurePathExistsOnAdd: true}
|
||||
patchedResource, err := patches.ApplyWithOptions(resource, options)
|
||||
if err != nil {
|
||||
return resource, err
|
||||
|
|
|
|||
|
|
@ -199,3 +199,179 @@ spec:
|
|||
})
|
||||
}
|
||||
}
|
||||
|
||||
func Test_MissingPaths(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
resource string
|
||||
patches string
|
||||
expectedPatches map[string]bool
|
||||
}{
|
||||
// test
|
||||
{
|
||||
name: "add-map-to-non-exist-path",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/nodeSelector"
|
||||
op: add
|
||||
value: {"node.kubernetes.io/role": "test"}
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"add","path":"/spec/nodeSelector","value":{"node.kubernetes.io/role":"test"}}`: true,
|
||||
},
|
||||
},
|
||||
// test
|
||||
{
|
||||
name: "add-to-non-exist-array",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/tolerations/0"
|
||||
op: add
|
||||
value: {"key": "node-role.kubernetes.io/test", "effect": "NoSchedule", "operator": "Exists"}
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"add","path":"/spec/tolerations","value":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/test","operator":"Exists"}]}`: true,
|
||||
},
|
||||
},
|
||||
// test
|
||||
{
|
||||
name: "add-to-non-exist-array-2",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/tolerations"
|
||||
op: add
|
||||
value: [{"key": "node-role.kubernetes.io/test", "effect": "NoSchedule", "operator": "Exists"}]
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"add","path":"/spec/tolerations","value":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/test","operator":"Exists"}]}`: true,
|
||||
},
|
||||
},
|
||||
// test
|
||||
{
|
||||
name: "add-to-non-exist-array-3",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/tolerations/-1"
|
||||
op: add
|
||||
value: {"key": "node-role.kubernetes.io/test", "effect": "NoSchedule", "operator": "Exists"}
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"add","path":"/spec/tolerations","value":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/test","operator":"Exists"}]}`: true,
|
||||
},
|
||||
},
|
||||
// test
|
||||
{
|
||||
name: "add-to-exist-array",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
tolerations:
|
||||
- effect: NoExecute
|
||||
key: node.kubernetes.io/not-ready
|
||||
operator: Exists
|
||||
tolerationSeconds: 300
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/tolerations"
|
||||
op: add
|
||||
value: [{"key": "node-role.kubernetes.io/test", "effect": "NoSchedule", "operator": "Exists"}]
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"replace","path":"/spec/tolerations/0/effect","value":"NoSchedule"}`: true,
|
||||
`{"op":"replace","path":"/spec/tolerations/0/key","value":"node-role.kubernetes.io/test"}`: true,
|
||||
`{"op":"remove","path":"/spec/tolerations/0/tolerationSeconds"}`: true,
|
||||
},
|
||||
},
|
||||
// test
|
||||
{
|
||||
name: "add-to-exist-array-2",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
tolerations:
|
||||
- effect: NoExecute
|
||||
key: node.kubernetes.io/not-ready
|
||||
operator: Exists
|
||||
tolerationSeconds: 300
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/tolerations/-"
|
||||
op: add
|
||||
value: {"key": "node-role.kubernetes.io/test", "effect": "NoSchedule", "operator": "Exists"}
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"add","path":"/spec/tolerations/1","value":{"effect":"NoSchedule","key":"node-role.kubernetes.io/test","operator":"Exists"}}`: true,
|
||||
},
|
||||
},
|
||||
// test
|
||||
{
|
||||
name: "add-to-exist-array-3",
|
||||
resource: `
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx:1.14.2
|
||||
tolerations:
|
||||
- effect: NoExecute
|
||||
key: node.kubernetes.io/not-ready
|
||||
operator: Exists
|
||||
tolerationSeconds: 300
|
||||
- key: "node.kubernetes.io/unreachable"
|
||||
operator: "Exists"
|
||||
effect: "NoExecute"
|
||||
tolerationSeconds: 6000
|
||||
`,
|
||||
patches: `
|
||||
- path: "/spec/tolerations/-1"
|
||||
op: add
|
||||
value: {"key": "node-role.kubernetes.io/test", "effect": "NoSchedule", "operator": "Exists"}
|
||||
`,
|
||||
expectedPatches: map[string]bool{
|
||||
`{"op":"add","path":"/spec/tolerations/2","value":{"effect":"NoSchedule","key":"node-role.kubernetes.io/test","operator":"Exists"}}`: true,
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, test := range tests {
|
||||
r, err := yaml.YAMLToJSON([]byte(test.resource))
|
||||
assert.Nil(t, err)
|
||||
|
||||
patches, err := yaml.YAMLToJSON([]byte(test.patches))
|
||||
assert.Nil(t, err)
|
||||
|
||||
patchedResource, err := applyPatchesWithOptions(r, patches)
|
||||
assert.Nil(t, err)
|
||||
|
||||
generatedP, err := generatePatches(r, patchedResource)
|
||||
assert.Nil(t, err)
|
||||
|
||||
for _, p := range generatedP {
|
||||
assert.Equal(t, test.expectedPatches[string(p)], true,
|
||||
fmt.Sprintf("test: %s\nunexpected patch: %s\nexpect one of: %v", test.name, string(p), test.expectedPatches))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -18,17 +18,17 @@ func Test_GeneratePatches(t *testing.T) {
|
|||
out, err := strategicMergePatch(string(baseBytes), string(overlayBytes))
|
||||
assert.NilError(t, err)
|
||||
|
||||
expectedPatches := [][]byte{
|
||||
[]byte(`{"op":"remove","path":"/spec/template/spec/containers/0"}`),
|
||||
[]byte(`{"op":"add","path":"/spec/template/spec/containers/0","value":{"image":"nginx","name":"nginx"}}`),
|
||||
[]byte(`{"op":"add","path":"/spec/template/spec/containers/1","value":{"env":[{"name":"WORDPRESS_DB_HOST","value":"$(MYSQL_SERVICE)"},{"name":"WORDPRESS_DB_PASSWORD","valueFrom":{"secretKeyRef":{"key":"password","name":"mysql-pass"}}}],"image":"wordpress:4.8-apache","name":"wordpress","ports":[{"containerPort":80,"name":"wordpress"}],"volumeMounts":[{"mountPath":"/var/www/html","name":"wordpress-persistent-storage"}]}}`),
|
||||
[]byte(`{"op":"add","path":"/spec/template/spec/initContainers","value":[{"command":["echo $(WORDPRESS_SERVICE)","echo $(MYSQL_SERVICE)"],"image":"debian","name":"init-command"}]}`),
|
||||
expectedPatches := map[string]bool{
|
||||
`{"op":"remove","path":"/spec/template/spec/containers/0"}`: true,
|
||||
`{"op":"add","path":"/spec/template/spec/containers/0","value":{"image":"nginx","name":"nginx"}}`: true,
|
||||
`{"op":"add","path":"/spec/template/spec/containers/1","value":{"env":[{"name":"WORDPRESS_DB_HOST","value":"$(MYSQL_SERVICE)"},{"name":"WORDPRESS_DB_PASSWORD","valueFrom":{"secretKeyRef":{"key":"password","name":"mysql-pass"}}}],"image":"wordpress:4.8-apache","name":"wordpress","ports":[{"containerPort":80,"name":"wordpress"}],"volumeMounts":[{"mountPath":"/var/www/html","name":"wordpress-persistent-storage"}]}}`: true,
|
||||
`{"op":"add","path":"/spec/template/spec/initContainers","value":[{"command":["echo $(WORDPRESS_SERVICE)","echo $(MYSQL_SERVICE)"],"image":"debian","name":"init-command"}]}`: true,
|
||||
}
|
||||
patches, err := generatePatches(baseBytes, out)
|
||||
assert.NilError(t, err)
|
||||
|
||||
for i, expect := range expectedPatches {
|
||||
assertnew.Equal(t, string(expect), string(patches[i]))
|
||||
for _, p := range patches {
|
||||
assertnew.Equal(t, expectedPatches[string(p)], true)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue