From 438a53cb3d4a9ade9b8c60127b9ef067a5230238 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Charles-Edouard=20Br=C3=A9t=C3=A9ch=C3=A9?=
 <charles.edouard@nirmata.com>
Date: Wed, 20 Dec 2023 09:37:26 +0100
Subject: [PATCH] feat: enable kubectl-validate by default in cli (#9220)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
---
 .github/workflows/cli.yaml                           | 4 ++--
 cmd/cli/kubectl-kyverno/experimental/experimental.go | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/cli.yaml b/.github/workflows/cli.yaml
index 932b042232..af983dc546 100644
--- a/.github/workflows/cli.yaml
+++ b/.github/workflows/cli.yaml
@@ -42,7 +42,7 @@ jobs:
           fi
       - name: Test CLI
         run: |
-          VERSION=${{ github.ref_name }} make test-cli
+          KYVERNO_KUBECTL_VALIDATE=false VERSION=${{ github.ref_name }} make test-cli
       - name: Test CLI (failures)
         run: |
           CLI_PATH=$PWD/cmd/cli/kubectl-kyverno/kubectl-kyverno
@@ -75,7 +75,7 @@ jobs:
           fi
       - name: Test CLI
         run: |
-          KYVERNO_KUBECTL_VALIDATE=true VERSION=${{ github.ref_name }} make test-cli
+          VERSION=${{ github.ref_name }} make test-cli
       - name: Test CLI (failures)
         run: |
           CLI_PATH=$PWD/cmd/cli/kubectl-kyverno/kubectl-kyverno
diff --git a/cmd/cli/kubectl-kyverno/experimental/experimental.go b/cmd/cli/kubectl-kyverno/experimental/experimental.go
index 772419f15a..4dfd238bce 100644
--- a/cmd/cli/kubectl-kyverno/experimental/experimental.go
+++ b/cmd/cli/kubectl-kyverno/experimental/experimental.go
@@ -10,17 +10,17 @@ const (
 	KubectlValidateEnv = "KYVERNO_KUBECTL_VALIDATE" //nolint:gosec
 )
 
-func getBool(env string) bool {
+func getBool(env string, fallback bool) bool {
 	if b, err := strconv.ParseBool(os.Getenv(env)); err == nil {
 		return b
 	}
-	return false
+	return fallback
 }
 
 func IsEnabled() bool {
-	return getBool(ExperimentalEnv)
+	return getBool(ExperimentalEnv, false)
 }
 
 func UseKubectlValidate() bool {
-	return getBool(KubectlValidateEnv)
+	return getBool(KubectlValidateEnv, true)
 }