move commonly used code to pkg/utils

pkg/utils/util.go

@@ -0,0 +1,10 @@
+package utils
+
+func Contains(list []string, element string) bool {
+	for _, e := range list {
+		if e == element {
+			return true
+		}
+	}
+	return false
+}

pkg/utils/util_test.go

@@ -0,0 +1,40 @@
+package utils
+
+import (
+	"testing"
+
+	"gotest.tools/assert"
+)
+
+func Test_allEmpty(t *testing.T) {
+	var list []string
+	var element string
+	res := Contains(list, element)
+	assert.Assert(t, res == false)
+}
+
+func Test_emptyList(t *testing.T) {
+	var list []string
+	element := "foo"
+	res := Contains(list, element)
+	assert.Assert(t, res == false)
+}
+
+func Test_emptyElement(t *testing.T) {
+	list := []string{"foo", "bar"}
+	var element string
+	res := Contains(list, element)
+	assert.Assert(t, res == false)
+}
+
+func Test_emptyElementInList(t *testing.T) {
+	list := []string{"foo", "bar", ""}
+	var element string
+	res := Contains(list, element)
+	assert.Assert(t, res == true)
+
+	list = []string{"foo", "bar", "bar"}
+	element = "bar"
+	res = Contains(list, element)
+	assert.Assert(t, res == true)
+}

pkg/webhooks/server.go

@@ -21,6 +21,7 @@ import (
 	"github.com/nirmata/kyverno/pkg/info"
 	"github.com/nirmata/kyverno/pkg/sharedinformer"
 	tlsutils "github.com/nirmata/kyverno/pkg/tls"
+	"github.com/nirmata/kyverno/pkg/utils"
 	v1beta1 "k8s.io/api/admission/v1beta1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
@@ -399,7 +400,7 @@ func (ws *WebhookServer) validateUniqueRuleName(rawPolicy []byte) *v1beta1.Admis
 	json.Unmarshal(rawPolicy, &policy)
 
 	for _, rule := range policy.Spec.Rules {
-		if contains(ruleNames, rule.Name) {
+		if utils.Contains(ruleNames, rule.Name) {
 			msg := fmt.Sprintf(`The policy "%s" is invalid: duplicate rule name: "%s"`, policy.Name, rule.Name)
 			glog.Errorln(msg)
 

pkg/webhooks/utils.go

@@ -63,12 +63,3 @@ func getApplicableKindsForPolicy(p *v1alpha1.Policy) []string {
 	}
 	return kinds
 }
-
-func contains(ruleNames []string, ruleName string) bool {
-	for _, rn := range ruleNames {
-		if rn == ruleName {
-			return true
-		}
-	}
-	return false
-}