mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

76 cache invalidate (#557)

Browse source 
* invalidate local cache of registererd resources

* update client in initContainer

* update message
This commit is contained in:
Shivkumar Dudhani 2019-12-16 12:55:44 -08:00 • committed by GitHub
parent 337e0f7d1d
commit 39e08aa1fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cmd/initContainer/main.go
View file

@ -7,6 +7,7 @@ import (
"flag"
"os"
"sync"
"time"
"github.com/golang/glog"
"github.com/nirmata/kyverno/pkg/config"
@ -41,7 +42,7 @@ func main() {
// DYNAMIC CLIENT
// - client for all registered resources
client, err := client.NewClient(clientConfig)
client, err := client.NewClient(clientConfig, 10*time.Second, stopCh)
if err != nil {
glog.Fatalf("Error creating client: %v\n", err)
}

5
cmd/kyverno/main.go
View file

@ -60,12 +60,13 @@ func main() {
// DYNAMIC CLIENT
// - client for all registered resources
client, err := dclient.NewClient(clientConfig)
// - invalidate local cache of registered resource every 10 seconds
client, err := dclient.NewClient(clientConfig, 10*time.Second, stopCh)
if err != nil {
glog.Fatalf("Error creating client: %v\n", err)
}
// CRD CHECK
// - verify if the CRD for Policy & PolicyViolation are avialalbe
// - verify if the CRD for Policy & PolicyViolation are available
if !utils.CRDInstalled(client.DiscoveryClient) {
glog.Fatalf("Required CRDs unavailable")
}

28
pkg/dclient/client.go
View file

@ -36,7 +36,7 @@ type Client struct {
}
//NewClient creates new instance of client
func NewClient(config *rest.Config) (*Client, error) {
func NewClient(config *rest.Config, resync time.Duration, stopCh <-chan struct{}) (*Client, error) {
dclient, err := dynamic.NewForConfig(config)
if err != nil {
return nil, err
@ -52,6 +52,13 @@ func NewClient(config *rest.Config) (*Client, error) {
}
// Set discovery client
discoveryClient := ServerPreferredResources{memory.NewMemCacheClient(kclient.Discovery())}
// client will invalidate registered resources cache every x seconds,
// As there is no way to identify if the registered resource is available or not
// we will be invalidating the local cache, so the next request get a fresh cache
// If a resource is removed then and cache is not invalidate yet, we will not detect the removal
// but the re-sync shall re-evaluate
go discoveryClient.Poll(resync, stopCh)
client.SetDiscovery(discoveryClient)
return &client, nil
}
@ -266,6 +273,25 @@ type ServerPreferredResources struct {
cachedClient discovery.CachedDiscoveryInterface
}
//Poll will keep invalidate the local cache
func (c ServerPreferredResources) Poll(resync time.Duration, stopCh <-chan struct{}) {
// start a ticker
ticker := time.NewTicker(resync)
defer func() { ticker.Stop() }()
glog.Infof("Starting registered resources sync: every %d seconds", resync)
for {
select {
case <-stopCh:
glog.Info("Stopping registered resources sync")
return
case <-ticker.C:
// set cache as stale
glog.V(6).Info("invalidating local client cache for registered resources")
c.cachedClient.Invalidate()
}
}
}
//GetGVRFromKind get the Group Version Resource from kind
// if kind is not found in first attempt we invalidate the cache,
// the retry will then fetch the new registered resources and check again