fix: kuttl test external-service (#5287)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/00-keda.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- keda.yaml
+assert:
+- keda-ready.yaml

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/01-cluster-policy.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- cluster-policy.yaml
+assert:
+- cluster-policy-ready.yaml

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/02-policy.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- policy.yaml
+assert:
+- policy-ready.yaml

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/02-sleep.yaml

@@ -1,5 +0,0 @@
-# Need to wait for the KEDA images to be pulled, Pods run, and external metrics API group to be properly registered and served.
-apiVersion: kuttl.dev/v1beta1
-kind: TestStep
-commands:
-  - command: sleep 20

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/03-assert.yaml

@@ -1,9 +0,0 @@
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  name: keda-metrics-apiserver
-  namespace: keda
-status:
-  availableReplicas: 1
-  readyReplicas: 1
-  replicas: 1

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/99-cleanup.yaml

@@ -1,4 +0,0 @@
-apiVersion: kuttl.dev/v1beta1
-kind: TestStep
-commands:
-  - command: kubectl delete -f 01-manifests.yaml,04-clusterpolicy.yaml,05-policy.yaml --force --wait=false --ignore-not-found=true

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/cluster-policy-ready.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
     name: external-metrics-policy
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/keda-ready.yaml

@@ -0,0 +1,19 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: keda-metrics-apiserver
+  namespace: keda
+status:
+  availableReplicas: 1
+  readyReplicas: 1
+  replicas: 1
+---
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  name: scaledobjects.keda.sh
+---
+apiVersion: apiregistration.k8s.io/v1
+kind: APIService
+metadata:
+  name: v1beta1.external.metrics.k8s.io

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/keda.yaml

@@ -12,7 +12,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.9.0
-  creationTimestamp: null
   labels:
     app.kubernetes.io/part-of: keda-operator
     app.kubernetes.io/version: 2.8.0
@@ -411,7 +410,6 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  creationTimestamp: null
   labels:
     app.kubernetes.io/name: keda-operator
     app.kubernetes.io/part-of: keda-operator

test/conformance/kuttl/validate/clusterpolicy/cornercases/external-metrics/policy-ready.yaml

@@ -4,4 +4,7 @@ metadata:
     name: external-metrics-policy-default
     namespace: default
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready