From 339cac028e4bef98817afd57e9887f1d50cd5a5b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Charles-Edouard=20Br=C3=A9t=C3=A9ch=C3=A9?=
 <charled.breteche@gmail.com>
Date: Thu, 7 Apr 2022 07:18:47 +0200
Subject: [PATCH] chore: add some make help comments (#3560)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
---
 Makefile | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/Makefile b/Makefile
index c7a3e39ae1..f23e31df3e 100644
--- a/Makefile
+++ b/Makefile
@@ -395,9 +395,8 @@ else
 CONTROLLER_GEN=$(shell which controller-gen)
 endif
 
-# Bootstrap auto-generable code associated with deepcopy
 .PHONY: deepcopy-autogen
-deepcopy-autogen: controller-gen
+deepcopy-autogen: controller-gen ## Generate deep copy code
 	$(CONTROLLER_GEN) object:headerFile="scripts/boilerplate.go.txt" paths="./..."
 
 .PHONY: codegen
@@ -421,7 +420,7 @@ verify-config: kyverno-crd report-crd ## Check config is up to date
 verify-codegen: verify-api verify-config verify-api-docs verify-helm ## Verify all generated code and docs are up to date
 
 .PHONY: goimports
-goimports:
+goimports: ## Install goimports if needed
 ifeq (, $(shell which goimports))
 	@{ \
 	echo "goimports not found!";\
@@ -432,13 +431,12 @@ else
 GO_IMPORTS=$(shell which goimports)
 endif
 
-# Run go fmt against code
 .PHONY: fmt
-fmt: goimports
+fmt: goimports ## Run go fmt
 	go fmt ./... && $(GO_IMPORTS) -w ./
 
 .PHONY: vet
-vet:
+vet: ## Run go vet
 	go vet ./...
 
 ##################################
@@ -467,15 +465,14 @@ verify-helm: gen-helm ## Check Helm charts are up to date
 help: ## Shows the available commands
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
 
-
 .PHONY: kind-deploy
 kind-deploy: docker-build-initContainer-local docker-build-kyverno-local
 	kind load docker-image $(REPO)/$(INITC_IMAGE):$(IMAGE_TAG_DEV)
 	kind load docker-image $(REPO)/$(KYVERNO_IMAGE):$(IMAGE_TAG_DEV)
-	helm upgrade --install kyverno --namespace kyverno --create-namespace ./charts/kyverno \
+	helm upgrade --install kyverno --namespace kyverno --wait --create-namespace ./charts/kyverno \
 		--set image.repository=$(REPO)/$(KYVERNO_IMAGE) \
 		--set image.tag=$(IMAGE_TAG_DEV) \
 		--set initImage.repository=$(REPO)/$(INITC_IMAGE) \
 		--set initImage.tag=$(IMAGE_TAG_DEV) \
-		--set extraArgs={--autogenInternals=true}
+		--set extraArgs={--autogenInternals=false}
 	helm upgrade --install kyverno-policies --namespace kyverno --create-namespace ./charts/kyverno-policies