From 2866c06d9572febb960514306275ceec8c6e2685 Mon Sep 17 00:00:00 2001
From: Prateek Pandey <prateek.pandey@nirmata.com>
Date: Tue, 10 May 2022 19:15:48 +0530
Subject: [PATCH] tests: add unit tests for utils functions (#3857)

Signed-off-by: prateekpandey14 <prateek.pandey@nirmata.com>
---
 pkg/policy/utils_test.go | 212 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 212 insertions(+)
 create mode 100644 pkg/policy/utils_test.go

diff --git a/pkg/policy/utils_test.go b/pkg/policy/utils_test.go
new file mode 100644
index 0000000000..5ac8d9ebad
--- /dev/null
+++ b/pkg/policy/utils_test.go
@@ -0,0 +1,212 @@
+package policy
+
+import (
+	"testing"
+
+	kyverno "github.com/kyverno/kyverno/api/kyverno/v1"
+	"gotest.tools/assert"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+)
+
+func Test_isMatchResourcesAllValid(t *testing.T) {
+
+	tests := []struct {
+		name string
+		rule kyverno.Rule
+		want bool
+	}{
+		{
+			name: "All with no kinds are invalid",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					All: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{},
+							},
+						},
+					},
+				},
+			},
+			want: false,
+		},
+
+		{
+			name: "All with same kind are valid",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					All: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1"},
+							},
+						},
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1"},
+							},
+						},
+					},
+				},
+			},
+			want: true,
+		},
+		{
+			name: "All with different kinds are invalid",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					All: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1"},
+							},
+						},
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind2"},
+							},
+						},
+					},
+				},
+			},
+			want: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.DeepEqual(t, tt.want, isMatchResourcesAllValid(tt.rule))
+		})
+	}
+}
+
+func Test_fetchUniqueKinds(t *testing.T) {
+
+	tests := []struct {
+		name string
+		rule kyverno.Rule
+		want []string
+	}{
+		{
+			name: "Unique MatchResource kinds",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					ResourceDescription: kyverno.ResourceDescription{
+						Kinds: []string{"kind1", "kind2"},
+					},
+				},
+			},
+			want: []string{"kind1", "kind2"},
+		},
+
+		{
+			name: "Any with same kind are valid",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					Any: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1", "kind2"},
+							},
+						},
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1", "kind3"},
+							},
+						},
+					},
+				},
+			},
+			want: []string{"kind1", "kind2", "kind3"},
+		},
+		{
+			name: "Match with All and Any kind",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					All: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1"},
+							},
+						},
+					},
+					Any: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1", "kind2"},
+							},
+						},
+					},
+				},
+			},
+			want: []string{"kind1", "kind2"},
+		},
+		{
+			name: "Match with different All and Any kind",
+			rule: kyverno.Rule{
+				MatchResources: kyverno.MatchResources{
+					All: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind4", "kind5"},
+							},
+						},
+					},
+					Any: []kyverno.ResourceFilter{
+						{
+							ResourceDescription: kyverno.ResourceDescription{
+								Kinds: []string{"kind1", "kind2"},
+							},
+						},
+					},
+				},
+			},
+			want: []string{"kind1", "kind2"},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.DeepEqual(t, fetchUniqueKinds(tt.rule), tt.want)
+		})
+	}
+}
+
+func Test_convertlist(t *testing.T) {
+	tests := []struct {
+		name   string
+		ulists []unstructured.Unstructured
+		want   []*unstructured.Unstructured
+	}{
+		{
+			name: "Convert list",
+			ulists: []unstructured.Unstructured{
+				{
+					Object: map[string]interface{}{
+						"kind": "kind1",
+					},
+				},
+				{
+					Object: map[string]interface{}{
+						"namespace": "ns-1",
+					},
+				},
+			},
+			want: []*unstructured.Unstructured{
+				{
+					Object: map[string]interface{}{
+						"kind": "kind1",
+					},
+				},
+				{
+					Object: map[string]interface{}{
+						"namespace": "ns-1",
+					},
+				},
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.DeepEqual(t, convertlist(tt.ulists), tt.want)
+		})
+	}
+}