mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

fix: add more verify images e2e test for bool fields (#4172)

Browse source 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>

Co-authored-by: Vyankatesh Kudtarkar <vyankateshkd@gmail.com>
This commit is contained in:
Charles-Edouard Brétéché 2022-06-30 21:36:28 +02:00 • committed by GitHub
parent 808e6ae8b7
commit 27e5772986
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test/e2e/framework/framework.go
View file

@ -17,7 +17,7 @@ func Setup(t *testing.T) {
}
}
func Run(t *testing.T, steps ...step.Step) {
func RunTest(t *testing.T, steps ...step.Step) {
ginkgo.By("Creating client ...")
client := client.New(t)
for _, step := range steps {
@ -25,3 +25,9 @@ func Run(t *testing.T, steps ...step.Step) {
}
ginkgo.By("Cleaning up ...")
}
func RunSubTest(t *testing.T, name string, steps ...step.Step) {
t.Run(name, func(t *testing.T) {
RunTest(t, steps...)
})
}

2
test/e2e/verifyimages/resources.go
View file

@ -221,6 +221,8 @@ spec:
verifyImages:
- image: "harbor2.zoller.com/cosign/*"
mutateDigest: false
verifyDigest: false
required: false
key: |-
-----BEGIN PUBLIC KEY-----
MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEpNlOGZ323zMlhs4bcKSpAKQvbcWi

34
test/e2e/verifyimages/verifyimages_test.go
View file

@ -156,20 +156,22 @@ func TestImageVerify(t *testing.T) {
func Test_BoolFields(t *testing.T) {
framework.Setup(t)
framework.Run(t,
step.CreateClusterPolicy(cpolVerifyImages),
step.By("Checking spec.rules[0].verifyImages[0].mutateDigest is false ..."),
step.ExpectResource(id.ClusterPolicy("verify-images"), func(resource *unstructured.Unstructured) {
rules, found, err := unstructured.NestedSlice(resource.UnstructuredContent(), "spec", "rules")
Expect(err).NotTo(HaveOccurred())
Expect(found).To(BeTrue())
verifyImages, found, err := unstructured.NestedSlice(rules[0].(map[string]interface{}), "verifyImages")
Expect(err).NotTo(HaveOccurred())
Expect(found).To(BeTrue())
mutateDigest, found, err := unstructured.NestedBool(verifyImages[0].(map[string]interface{}), "mutateDigest")
Expect(err).NotTo(HaveOccurred())
Expect(found).To(BeTrue())
Expect(mutateDigest).To(BeFalse())
}),
)
for _, field := range []string{"mutateDigest", "verifyDigest", "required"} {
framework.RunSubTest(t, field,
step.CreateClusterPolicy(cpolVerifyImages),
step.By(fmt.Sprintf("Checking spec.rules[0].verifyImages[0].%s is false ...", field)),
step.ExpectResource(id.ClusterPolicy("verify-images"), func(resource *unstructured.Unstructured) {
rules, found, err := unstructured.NestedSlice(resource.UnstructuredContent(), "spec", "rules")
Expect(err).NotTo(HaveOccurred())
Expect(found).To(BeTrue())
verifyImages, found, err := unstructured.NestedSlice(rules[0].(map[string]interface{}), "verifyImages")
Expect(err).NotTo(HaveOccurred())
Expect(found).To(BeTrue())
mutateDigest, found, err := unstructured.NestedBool(verifyImages[0].(map[string]interface{}), field)
Expect(err).NotTo(HaveOccurred())
Expect(found).To(BeTrue())
Expect(mutateDigest).To(BeFalse())
}),
)
}
}