mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

chore: enable wastedassign linter (#3898)

Browse source 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
This commit is contained in:
Charles-Edouard Brétéché 2022-05-12 13:03:26 +02:00 • committed by GitHub
parent bd78f02510
commit 26a5402747
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.golangci.yml
View file

@ -25,6 +25,7 @@ linters:
- unconvert - unconvert
- unused - unused
- varcheck - varcheck
- wastedassign
- whitespace - whitespace
run: run:

4
pkg/common/common.go
View file

@ -90,7 +90,7 @@ func ProcessDeletePolicyForCloneGenerateRule(policy kyverno.PolicyInterface, cli
logger.V(4).Info("generate policy with clone, remove policy name from label of source resource") logger.V(4).Info("generate policy with clone, remove policy name from label of source resource")
generatePolicyWithClone = true generatePolicyWithClone = true
retryCount := 0 var retryCount int
for retryCount < 5 { for retryCount < 5 {
err := updateSourceResource(policy.GetName(), rule, client, logger) err := updateSourceResource(policy.GetName(), rule, client, logger)
if err != nil { if err != nil {
@ -114,7 +114,7 @@ func updateSourceResource(pName string, rule kyverno.Rule, client dclient.Interf
return errors.Wrapf(err, "source resource %s/%s/%s not found", rule.Generation.Kind, rule.Generation.Clone.Namespace, rule.Generation.Clone.Name) return errors.Wrapf(err, "source resource %s/%s/%s not found", rule.Generation.Kind, rule.Generation.Clone.Namespace, rule.Generation.Clone.Name)
} }
update := false var update bool
labels := obj.GetLabels() labels := obj.GetLabels()
update, labels = removePolicyFromLabels(pName, labels) update, labels = removePolicyFromLabels(pName, labels)
if !update { if !update {

2
pkg/policyreport/changerequestcreator.go
View file

@ -85,7 +85,7 @@ func (c *changeRequestCreator) add(request *unstructured.Unstructured) {
} }
func (c *changeRequestCreator) create(request *unstructured.Unstructured) error { func (c *changeRequestCreator) create(request *unstructured.Unstructured) error {
ns := "" var ns string
if request.GetKind() == "ReportChangeRequest" { if request.GetKind() == "ReportChangeRequest" {
ns = config.KyvernoNamespace() ns = config.KyvernoNamespace()
rcr, err := convertToRCR(request) rcr, err := convertToRCR(request)