mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-04-09 02:29:22 +00:00
Code Activity

update pv labels if it changes

Browse source
This commit is contained in:
Shuting Zhao 2019-11-13 00:03:01 -08:00
parent 55b0bf0d3a
commit 196c7b36b0
1 changed files with 41 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
pkg/policy/namespacedpv.go
View file

@ -20,9 +20,9 @@ func (pc *PolicyController) addNamespacedPolicyViolation(obj interface{}) {
}
// generate labels to match the policy from the spec, if not present
// if updatePolicyLabelIfNotDefined(pc.pvControl, nil) {
// return
// }
if updateLabels(pv) {
return
}
// If it has a ControllerRef, that's all that matters.
if controllerRef := metav1.GetControllerOf(pv); controllerRef != nil {
@ -64,9 +64,9 @@ func (pc *PolicyController) updateNamespacedPolicyViolation(old, cur interface{}
}
// generate labels to match the policy from the spec, if not present
// if updatePolicyLabelIfNotDefined(pc.pvControl, curPV) {
// return
// }
if updateLabels(curPV) {
return
}
curControllerRef := metav1.GetControllerOf(curPV)
oldControllerRef := metav1.GetControllerOf(oldPV)
@ -141,6 +141,41 @@ func (pc *PolicyController) deleteNamespacedPolicyViolation(obj interface{}) {
pc.enqueuePolicy(p)
}
func updateLabels(pv *kyverno.NamespacedPolicyViolation) bool {
if pv.Spec.Policy == "" {
glog.Error("policy not defined for violation")
// should be cleaned up
return false
}
labels := pv.GetLabels()
newLabels := labels
if newLabels == nil {
newLabels = make(map[string]string)
}
policy, ok := newLabels["policy"]
// key 'policy' does not present
// or policy name has changed
if !ok || policy != pv.Spec.Policy {
newLabels["policy"] = pv.Spec.Policy
}
resource, ok := newLabels["resource"]
// key 'resource' does not present
// or resource defined in policy has changed
if !ok || resource != pv.Spec.ResourceSpec.ToKey() {
newLabels["resource"] = pv.Spec.ResourceSpec.ToKey()
}
if !reflect.DeepEqual(labels, newLabels) {
pv.SetLabels(labels)
return true
}
return false
}
func (pc *PolicyController) getPolicyForNamespacedPolicyViolation(pv *kyverno.NamespacedPolicyViolation) []*kyverno.ClusterPolicy {
policies, err := pc.pLister.GetPolicyForNamespacedPolicyViolation(pv)
if err != nil || len(policies) == 0 {