From 18d4dadab68a5bc82552b7949c2c517eadb6b81c Mon Sep 17 00:00:00 2001
From: Abhi Kapoor <43758739+abhi-kapoor@users.noreply.github.com>
Date: Tue, 5 Apr 2022 06:08:01 -0400
Subject: [PATCH] Do not generate preconditions not met warning for audit
 policies (#3487)

* Do not generate preconditions not met warning for audit policies

Signed-off-by: abhi-kapoor <43758739+abhi-kapoor@users.noreply.github.com>

* Update PR template to reeference the closing keyword

Signed-off-by: abhi-kapoor <43758739+abhi-kapoor@users.noreply.github.com>

* Update pkg/engine/validation.go

Co-authored-by: Prateek Pandey <prateekpandey14@gmail.com>

* Update pkg/engine/validation.go

Co-authored-by: Prateek Pandey <prateekpandey14@gmail.com>

Co-authored-by: Prateek Pandey <prateek.pandey@nirmata.com>
Co-authored-by: shuting <shutting06@gmail.com>
Co-authored-by: Prateek Pandey <prateekpandey14@gmail.com>
Co-authored-by: shuting <shuting@nirmata.com>
---
 .github/PULL_REQUEST_TEMPLATE.md | 2 +-
 pkg/engine/validation.go         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index d8b8d997da..5f6f2166da 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,7 +1,7 @@
 ## Related issue
 
 <!--
-Please link the GitHub issue this pull request resolves in the format of `#1234`. If you discussed this change
+Please link the GitHub issue this pull request resolves in the format of `Closes #1234`. If you discussed this change
 with a maintainer, please mention her/him using the `@` syntax (e.g. `@JimBugwadia`).
 
 If this change neither resolves an existing issue nor has sign-off from one of the maintainers, there is a
diff --git a/pkg/engine/validation.go b/pkg/engine/validation.go
index 6c58f9cae3..9fa04045c5 100644
--- a/pkg/engine/validation.go
+++ b/pkg/engine/validation.go
@@ -206,7 +206,7 @@ func (v *validator) validate() *response.RuleResponse {
 		return ruleError(v.rule, utils.Validation, "failed to evaluate preconditions", err)
 	}
 
-	if !preconditionsPassed {
+	if !preconditionsPassed && v.ctx.Policy.GetSpec().ValidationFailureAction != kyverno.Audit {
 		return ruleResponse(v.rule, utils.Validation, "preconditions not met", response.RuleStatusSkip)
 	}
 
@@ -247,7 +247,7 @@ func (v *validator) validateForEach() *response.RuleResponse {
 	preconditionsPassed, err := checkPreconditions(v.log, v.ctx, v.anyAllConditions)
 	if err != nil {
 		return ruleError(v.rule, utils.Validation, "failed to evaluate preconditions", err)
-	} else if !preconditionsPassed {
+	} else if !preconditionsPassed && v.ctx.Policy.GetSpec().ValidationFailureAction != kyverno.Audit {
 		return ruleResponse(v.rule, utils.Validation, "preconditions not met", response.RuleStatusSkip)
 	}