chore: use conditions in kuttl tests to check ready policies (#5252)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: shuting <shuting@nirmata.com>

test/conformance/kuttl/aaa_template_resources/01-assert.yaml

@@ -5,4 +5,7 @@ kind: ClusterPolicy
 metadata:
   name: add-labels
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/clone/nosync/cpol-clone-nosync-create/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: cpol-nosync-clone
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/clone/nosync/cpol-clone-nosync-delete-downstream/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: cpol-nosync-clone
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-sync-create/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: cpol-sync-clone
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/clone/sync/cpol-clone-sync-delete-downstream/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: cpol-sync-clone
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/data/nosync/cpol-data-nosync-delete-downstream/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: zk-kafka-address
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/data/sync/cpol-data-sync-create/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: zk-kafka-address
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/data/sync/cpol-data-sync-delete-policy/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: zk-kafka-address
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/generate/clusterpolicy/standard/data/sync/cpol-data-sync-modify-rule/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: zk-kafka-address
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/mutate/clusterpolicy/standard/basic-check-output/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: add-labels
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/mutate/clusterpolicy/standard/existing/basic/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: mutate-existing-secret
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/reports/admission/test-report-admission-mode/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: require-owner
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/reports/background/test-report-background-mode/02-assert.yaml

@@ -17,4 +17,7 @@ spec:
         version: latest
   validationFailureAction: audit
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/validate/clusterpolicy/standard/enforce/resource-apply-block/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: require-owner
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/imageExtractors-complex-keyless/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: tasks-keyless
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/imageExtractors-complex/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: tasks-complex
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/imageExtractors-none/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: tasks-no-extractor
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/imageExtractors-simple/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: tasks-simple
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/keyed-secret/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: secret-in-keys
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/keyless-mutatedigest-verifydigest-required/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: keyless-mutatedigest-verifydigest-required
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/keyless-nomutatedigest-noverifydigest-norequired/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: keyless-nomutatedigest-noverifydigest-norequired
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready

test/conformance/kuttl/verifyImages/clusterpolicy/standard/keyless-nomutatedigest-noverifydigest-required/01-assert.yaml

@@ -3,4 +3,7 @@ kind: ClusterPolicy
 metadata:
   name: keyless-nomutatedigest-noverifydigest-required
 status:
-  ready: true
+  conditions:
+  - reason: Succeeded
+    status: "True"
+    type: Ready