From 08def22d046797e54d9973a7f45be30d55c5eb22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Charles-Edouard=20Br=C3=A9t=C3=A9ch=C3=A9?= Date: Tue, 21 Mar 2023 13:47:50 +0100 Subject: [PATCH] fix: incorrect old resource check (#6635) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Charles-Edouard Brétéché --- pkg/engine/validation.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/engine/validation.go b/pkg/engine/validation.go index 21ad85b0a0..0f95867f78 100644 --- a/pkg/engine/validation.go +++ b/pkg/engine/validation.go @@ -518,9 +518,9 @@ func matches( if err == nil { return true } - - if !reflect.DeepEqual(ctx.OldResource, unstructured.Unstructured{}) { - err := MatchesResourceDescription(subresourceGVKToAPIResource, ctx.OldResource(), *rule, ctx.AdmissionInfo(), cfg.GetExcludedGroups(), ctx.NamespaceLabels(), "", ctx.SubResource()) + oldResource := ctx.OldResource() + if oldResource.Object != nil { + err := MatchesResourceDescription(subresourceGVKToAPIResource, oldResource, *rule, ctx.AdmissionInfo(), cfg.GetExcludedGroups(), ctx.NamespaceLabels(), "", ctx.SubResource()) if err == nil { return true }