fix: unsupported defaults in api (#11021)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

api/kyverno/v1/rule_types.go

@@ -108,7 +108,7 @@ type Rule struct {
 	// generate and mutateExisting rules to those requests.
 	// +kubebuilder:default=true
 	// +kubebuilder:validation:Optional
-	SkipBackgroundRequests bool `json:"skipBackgroundRequests,omitempty"`
+	SkipBackgroundRequests *bool `json:"skipBackgroundRequests,omitempty"`
 }
 
 // HasMutate checks for mutate rule

api/kyverno/v1/zz_generated.deepcopy.go

@@ -1415,6 +1415,11 @@ func (in *Rule) DeepCopyInto(out *Rule) {
 			(*in)[i].DeepCopyInto(&(*out)[i])
 		}
 	}
+	if in.SkipBackgroundRequests != nil {
+		in, out := &in.SkipBackgroundRequests, &out.SkipBackgroundRequests
+		*out = new(bool)
+		**out = **in
+	}
 	return
 }
 

api/kyverno/v2beta1/rule_types.go

@@ -71,7 +71,7 @@ type Rule struct {
 	// generate and mutateExisting rules to those requests.
 	// +kubebuilder:default=true
 	// +kubebuilder:validation:Optional
-	SkipBackgroundRequests bool `json:"skipBackgroundRequests,omitempty"`
+	SkipBackgroundRequests *bool `json:"skipBackgroundRequests,omitempty"`
 }
 
 // HasMutate checks for mutate rule

api/kyverno/v2beta1/zz_generated.deepcopy.go

@@ -748,6 +748,11 @@ func (in *Rule) DeepCopyInto(out *Rule) {
 			(*in)[i].DeepCopyInto(&(*out)[i])
 		}
 	}
+	if in.SkipBackgroundRequests != nil {
+		in, out := &in.SkipBackgroundRequests, &out.SkipBackgroundRequests
+		*out = new(bool)
+		**out = **in
+	}
 	return
 }
 

pkg/webhooks/resource/utils.go

@@ -105,7 +105,11 @@ func skipBackgroundRequests(policy kyvernov1.PolicyInterface, logger logr.Logger
 	policyNew := policy.CreateDeepCopy()
 	policyNew.GetSpec().Rules = nil
 	for _, rule := range policy.GetSpec().Rules {
-		if rule.SkipBackgroundRequests && (bgsaDesired == bgsaActual) {
+		skipBackgroundRequests := true
+		if rule.SkipBackgroundRequests != nil {
+			skipBackgroundRequests = *rule.SkipBackgroundRequests
+		}
+		if skipBackgroundRequests && (bgsaDesired == bgsaActual) {
 			continue
 		}
 		logger.V(4).Info("applying background rule", "rule", rule.Name, "skipBackgroundRequests", rule.SkipBackgroundRequests, "backgroundSaDesired", bgsaDesired, "backgroundSaActual", bgsaActual)