1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2024-12-15 17:51:20 +00:00
kyverno/pkg/engine/validation.go

308 lines
10 KiB
Go
Raw Normal View History

2019-05-14 01:17:28 +00:00
package engine
import (
"fmt"
"reflect"
2019-08-19 23:40:10 +00:00
"time"
2019-05-16 16:31:02 +00:00
2020-03-17 18:05:20 +00:00
"github.com/go-logr/logr"
2019-11-13 21:41:08 +00:00
kyverno "github.com/nirmata/kyverno/pkg/api/kyverno/v1"
"github.com/nirmata/kyverno/pkg/engine/context"
"github.com/nirmata/kyverno/pkg/engine/response"
"github.com/nirmata/kyverno/pkg/engine/utils"
"github.com/nirmata/kyverno/pkg/engine/validate"
593 feature (#594) * initial commit * background policy validation * correct message * skip non-background policy process for add/update * add Generate Request CR * generate Request Generator Initial * test generate request CR generation * initial commit gr generator * generate controller initial framework * add crd for generate request * gr cleanup controller initial commit * cleanup controller initial * generate mid-commit * generate rule processing * create PV on generate error * embed resource type * testing phase 1- generate resources with variable substitution * fix tests * comment broken test #586 * add printer column for state * return if existing resource for clone * set resync time to 2 mins & remove resource version check in update handler for gr * generate events for reporting * fix logs * initial commit * fix trailing quote in patch * remove comments * initial condition (equal & notequal) * initial support for conditions * initial support fo conditions in generate * support precondition checks * cleanup * re-evaluate GR on namespace update using dynamic informers * add status for generated resources * display loaded variable SA * support delete cleanup of generate request main resources * fix log * remove namespace from SA username * support multiple variables per statement for scalar values * fix fail variables * add check for userInfo * validation checks for conditions * update policy * refactor logs * code review * add openapispec for clusterpolicy preconditions * Update documentation * CR fixes * documentation * CR fixes * update variable * fix logs * update policy * pre-defined variables (serviceAccountName & serviceAccountNamespace) * update test
2020-01-07 23:13:57 +00:00
"github.com/nirmata/kyverno/pkg/engine/variables"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
2020-03-17 23:25:34 +00:00
"sigs.k8s.io/controller-runtime/pkg/log"
)
2019-09-03 22:48:13 +00:00
//Validate applies validation rules from policy on the resource
2020-05-05 15:28:02 +00:00
func Validate(policyContext PolicyContext) (resp response.EngineResponse) {
2019-09-03 22:48:13 +00:00
startTime := time.Now()
policy := policyContext.Policy
newR := policyContext.NewResource
oldR := policyContext.OldResource
ctx := policyContext.Context
admissionInfo := policyContext.AdmissionInfo
logger := log.Log.WithName("Validate").WithValues("policy", policy.Name)
if reflect.DeepEqual(newR, unstructured.Unstructured{}) {
logger = logger.WithValues("kind", oldR.GetKind(), "namespace", oldR.GetNamespace(), "name", oldR.GetName())
} else {
logger = logger.WithValues("kind", newR.GetKind(), "namespace", newR.GetNamespace(), "name", newR.GetName())
}
2020-03-17 18:05:20 +00:00
logger.V(4).Info("start processing", "startTime", startTime)
2020-05-05 15:28:02 +00:00
defer func() {
if reflect.DeepEqual(resp, response.EngineResponse{}) {
return
}
2020-05-05 18:22:52 +00:00
var resource unstructured.Unstructured
2020-05-05 15:28:02 +00:00
if reflect.DeepEqual(resp.PatchedResource, unstructured.Unstructured{}) {
// for delete requests patched resource will be oldR since newR is empty
if reflect.DeepEqual(newR, unstructured.Unstructured{}) {
2020-05-05 18:22:52 +00:00
resource = oldR
2020-05-05 15:28:02 +00:00
} else {
2020-05-05 18:22:52 +00:00
resource = newR
}
}
for i := range resp.PolicyResponse.Rules {
messageInterface, err := variables.SubstituteVars(logger, ctx, resp.PolicyResponse.Rules[i].Message)
if err != nil {
continue
2020-05-05 15:28:02 +00:00
}
2020-05-05 18:22:52 +00:00
resp.PolicyResponse.Rules[i].Message, _ = messageInterface.(string)
2020-05-05 15:28:02 +00:00
}
2020-05-05 18:22:52 +00:00
resp.PatchedResource = resource
startResultResponse(&resp, policy, resource)
endResultResponse(logger, &resp, startTime)
2020-05-05 15:28:02 +00:00
}()
// If request is delete, newR will be empty
if reflect.DeepEqual(newR, unstructured.Unstructured{}) {
return *isRequestDenied(logger, ctx, policy, oldR, admissionInfo)
}
if denyResp := isRequestDenied(logger, ctx, policy, newR, admissionInfo); !denyResp.IsSuccessful() {
return *denyResp
2019-09-03 22:48:13 +00:00
}
2020-04-22 14:45:16 +00:00
2020-05-05 13:49:47 +00:00
if reflect.DeepEqual(oldR, unstructured.Unstructured{}) {
2020-05-05 15:28:02 +00:00
return *validateResource(logger, ctx, policy, newR, admissionInfo)
2020-05-05 13:49:47 +00:00
}
2020-05-05 15:28:02 +00:00
2020-05-05 13:49:47 +00:00
oldResponse := validateResource(logger, ctx, policy, oldR, admissionInfo)
newResponse := validateResource(logger, ctx, policy, newR, admissionInfo)
if !isSameResponse(oldResponse, newResponse) {
return *newResponse
}
2020-05-05 13:49:47 +00:00
return response.EngineResponse{}
}
func startResultResponse(resp *response.EngineResponse, policy kyverno.ClusterPolicy, newR unstructured.Unstructured) {
// set policy information
resp.PolicyResponse.Policy = policy.Name
// resource details
resp.PolicyResponse.Resource.Name = newR.GetName()
resp.PolicyResponse.Resource.Namespace = newR.GetNamespace()
resp.PolicyResponse.Resource.Kind = newR.GetKind()
resp.PolicyResponse.Resource.APIVersion = newR.GetAPIVersion()
resp.PolicyResponse.ValidationFailureAction = policy.Spec.ValidationFailureAction
}
2020-03-17 18:05:20 +00:00
func endResultResponse(log logr.Logger, resp *response.EngineResponse, startTime time.Time) {
resp.PolicyResponse.ProcessingTime = time.Since(startTime)
2020-03-17 18:05:20 +00:00
log.V(4).Info("finshed processing", "processingTime", resp.PolicyResponse.ProcessingTime, "validationRulesApplied", resp.PolicyResponse.RulesAppliedCount)
}
func incrementAppliedCount(resp *response.EngineResponse) {
// rules applied successfully count
resp.PolicyResponse.RulesAppliedCount++
}
2020-05-05 13:49:47 +00:00
func isRequestDenied(log logr.Logger, ctx context.EvalInterface, policy kyverno.ClusterPolicy, resource unstructured.Unstructured, admissionInfo kyverno.RequestInfo) *response.EngineResponse {
resp := &response.EngineResponse{}
2019-09-03 22:48:13 +00:00
for _, rule := range policy.Spec.Rules {
2019-10-21 21:22:31 +00:00
if !rule.HasValidate() {
2019-09-03 22:48:13 +00:00
continue
}
2019-11-12 05:06:09 +00:00
if err := MatchesResourceDescription(resource, rule, admissionInfo); err != nil {
log.V(4).Info("resource fails the match description", "reason", err.Error())
2019-09-03 22:48:13 +00:00
continue
}
593 feature (#594) * initial commit * background policy validation * correct message * skip non-background policy process for add/update * add Generate Request CR * generate Request Generator Initial * test generate request CR generation * initial commit gr generator * generate controller initial framework * add crd for generate request * gr cleanup controller initial commit * cleanup controller initial * generate mid-commit * generate rule processing * create PV on generate error * embed resource type * testing phase 1- generate resources with variable substitution * fix tests * comment broken test #586 * add printer column for state * return if existing resource for clone * set resync time to 2 mins & remove resource version check in update handler for gr * generate events for reporting * fix logs * initial commit * fix trailing quote in patch * remove comments * initial condition (equal & notequal) * initial support for conditions * initial support fo conditions in generate * support precondition checks * cleanup * re-evaluate GR on namespace update using dynamic informers * add status for generated resources * display loaded variable SA * support delete cleanup of generate request main resources * fix log * remove namespace from SA username * support multiple variables per statement for scalar values * fix fail variables * add check for userInfo * validation checks for conditions * update policy * refactor logs * code review * add openapispec for clusterpolicy preconditions * Update documentation * CR fixes * documentation * CR fixes * update variable * fix logs * update policy * pre-defined variables (serviceAccountName & serviceAccountNamespace) * update test
2020-01-07 23:13:57 +00:00
2020-04-14 15:17:12 +00:00
preconditionsCopy := copyConditions(rule.Conditions)
2020-05-05 13:49:47 +00:00
2020-04-14 15:17:12 +00:00
if !variables.EvaluateConditions(log, ctx, preconditionsCopy) {
2020-03-17 18:05:20 +00:00
log.V(4).Info("resource fails the preconditions")
593 feature (#594) * initial commit * background policy validation * correct message * skip non-background policy process for add/update * add Generate Request CR * generate Request Generator Initial * test generate request CR generation * initial commit gr generator * generate controller initial framework * add crd for generate request * gr cleanup controller initial commit * cleanup controller initial * generate mid-commit * generate rule processing * create PV on generate error * embed resource type * testing phase 1- generate resources with variable substitution * fix tests * comment broken test #586 * add printer column for state * return if existing resource for clone * set resync time to 2 mins & remove resource version check in update handler for gr * generate events for reporting * fix logs * initial commit * fix trailing quote in patch * remove comments * initial condition (equal & notequal) * initial support for conditions * initial support fo conditions in generate * support precondition checks * cleanup * re-evaluate GR on namespace update using dynamic informers * add status for generated resources * display loaded variable SA * support delete cleanup of generate request main resources * fix log * remove namespace from SA username * support multiple variables per statement for scalar values * fix fail variables * add check for userInfo * validation checks for conditions * update policy * refactor logs * code review * add openapispec for clusterpolicy preconditions * Update documentation * CR fixes * documentation * CR fixes * update variable * fix logs * update policy * pre-defined variables (serviceAccountName & serviceAccountNamespace) * update test
2020-01-07 23:13:57 +00:00
continue
}
2020-04-14 15:17:12 +00:00
if rule.Validation.Deny != nil {
2020-04-18 12:56:09 +00:00
denyConditionsCopy := copyConditions(rule.Validation.Deny.Conditions)
if len(rule.Validation.Deny.Conditions) == 0 || variables.EvaluateConditions(log, ctx, denyConditionsCopy) {
2020-04-14 15:17:12 +00:00
ruleResp := response.RuleResponse{
Name: rule.Name,
Type: utils.Validation.String(),
Message: rule.Validation.Message,
Success: false,
}
resp.PolicyResponse.Rules = append(resp.PolicyResponse.Rules, ruleResp)
}
continue
}
2020-05-05 13:49:47 +00:00
}
return resp
}
func validateResource(log logr.Logger, ctx context.EvalInterface, policy kyverno.ClusterPolicy, resource unstructured.Unstructured, admissionInfo kyverno.RequestInfo) *response.EngineResponse {
resp := &response.EngineResponse{}
if autoGenAnnotationApplied(resource) && policy.HasAutoGenAnnotation() {
return resp
}
2020-05-05 13:49:47 +00:00
for _, rule := range policy.Spec.Rules {
if !rule.HasValidate() {
continue
}
// check if the resource satisfies the filter conditions defined in the rule
// TODO: this needs to be extracted, to filter the resource so that we can avoid passing resources that
2020-05-19 20:04:06 +00:00
// dont satisfy a policy rule resource description
2020-05-05 13:49:47 +00:00
if err := MatchesResourceDescription(resource, rule, admissionInfo); err != nil {
log.V(4).Info("resource fails the match description", "reason", err.Error())
2020-05-05 13:49:47 +00:00
continue
}
// operate on the copy of the conditions, as we perform variable substitution
preconditionsCopy := copyConditions(rule.Conditions)
// evaluate pre-conditions
// - handle variable subsitutions
if !variables.EvaluateConditions(log, ctx, preconditionsCopy) {
log.V(4).Info("resource fails the preconditions")
continue
}
if rule.Validation.Pattern != nil || rule.Validation.AnyPattern != nil {
ruleResponse := validatePatterns(log, ctx, resource, rule)
incrementAppliedCount(resp)
resp.PolicyResponse.Rules = append(resp.PolicyResponse.Rules, ruleResponse)
2019-09-03 22:48:13 +00:00
}
2020-04-22 14:45:16 +00:00
2019-09-03 22:48:13 +00:00
}
return resp
}
func isSameResponse(oldResponse, newResponse *response.EngineResponse) bool {
// if the response are same then return true
return isSamePolicyResponse(oldResponse.PolicyResponse, newResponse.PolicyResponse)
}
func isSamePolicyResponse(oldPolicyRespone, newPolicyResponse response.PolicyResponse) bool {
// can skip policy and resource checks as they will be same
// compare rules
return isSameRules(oldPolicyRespone.Rules, newPolicyResponse.Rules)
}
func isSameRules(oldRules []response.RuleResponse, newRules []response.RuleResponse) bool {
if len(oldRules) != len(newRules) {
return false
}
// as the rules are always processed in order the indices wil be same
for idx, oldrule := range oldRules {
newrule := newRules[idx]
// Name
if oldrule.Name != newrule.Name {
return false
}
// Type
if oldrule.Type != newrule.Type {
return false
}
// Message
if oldrule.Message != newrule.Message {
return false
}
// skip patches
if oldrule.Success != newrule.Success {
return false
}
}
return true
2019-09-03 22:48:13 +00:00
}
2019-08-21 19:38:15 +00:00
// validatePatterns validate pattern and anyPattern
2020-03-17 18:05:20 +00:00
func validatePatterns(log logr.Logger, ctx context.EvalInterface, resource unstructured.Unstructured, rule kyverno.Rule) (resp response.RuleResponse) {
2019-08-24 01:34:23 +00:00
startTime := time.Now()
2020-03-17 18:05:20 +00:00
logger := log.WithValues("rule", rule.Name)
logger.V(4).Info("start processing rule", "startTime", startTime)
resp.Name = rule.Name
resp.Type = utils.Validation.String()
2019-08-24 01:34:23 +00:00
defer func() {
resp.RuleStats.ProcessingTime = time.Since(startTime)
logger.V(4).Info("finished processing rule", "processingTime", resp.RuleStats.ProcessingTime)
2019-08-24 01:34:23 +00:00
}()
2020-02-14 19:59:28 +00:00
// work on a copy of validation rule
validationRule := rule.Validation.DeepCopy()
2019-08-09 19:59:37 +00:00
2019-08-24 01:34:23 +00:00
// either pattern or anyPattern can be specified in Validation rule
2020-02-14 19:59:28 +00:00
if validationRule.Pattern != nil {
// substitute variables in the pattern
pattern := validationRule.Pattern
var err error
2020-03-17 18:05:20 +00:00
if pattern, err = variables.SubstituteVars(logger, ctx, pattern); err != nil {
2020-02-14 19:59:28 +00:00
// variable subsitution failed
resp.Success = false
resp.Message = fmt.Sprintf("Validation error: %s; Validation rule '%s' failed. '%s'",
rule.Validation.Message, rule.Name, err)
return resp
}
2020-03-17 18:05:20 +00:00
if path, err := validate.ValidateResourceWithPattern(logger, resource.Object, pattern); err != nil {
2020-02-14 19:59:28 +00:00
// validation failed
resp.Success = false
2020-05-20 20:43:12 +00:00
resp.Message = fmt.Sprintf("Validation error: %s; Validation rule %s failed at path %s",
2020-02-14 19:59:28 +00:00
rule.Validation.Message, rule.Name, path)
return resp
}
// rule application successful
2020-03-17 18:05:20 +00:00
logger.V(4).Info("successfully processed rule")
resp.Success = true
resp.Message = fmt.Sprintf("Validation rule '%s' succeeded.", rule.Name)
return resp
}
2020-02-14 19:59:28 +00:00
if validationRule.AnyPattern != nil {
var failedSubstitutionsErrors []error
var failedAnyPatternsErrors []error
var err error
for idx, pattern := range validationRule.AnyPattern {
2020-03-17 18:05:20 +00:00
if pattern, err = variables.SubstituteVars(logger, ctx, pattern); err != nil {
2020-02-14 19:59:28 +00:00
// variable subsitution failed
failedSubstitutionsErrors = append(failedSubstitutionsErrors, err)
continue
}
2020-03-17 18:05:20 +00:00
_, err := validate.ValidateResourceWithPattern(logger, resource.Object, pattern)
2020-02-14 19:59:28 +00:00
if err == nil {
resp.Success = true
2020-02-14 19:59:28 +00:00
resp.Message = fmt.Sprintf("Validation rule '%s' anyPattern[%d] succeeded.", rule.Name, idx)
return resp
}
2020-03-17 18:05:20 +00:00
logger.V(4).Info(fmt.Sprintf("validation rule failed for anyPattern[%d]", idx), "message", rule.Validation.Message)
2020-02-14 19:59:28 +00:00
patternErr := fmt.Errorf("anyPattern[%d] failed; %s", idx, err)
failedAnyPatternsErrors = append(failedAnyPatternsErrors, patternErr)
}
2020-02-14 19:59:28 +00:00
// Subsitution falures
if len(failedSubstitutionsErrors) > 0 {
resp.Success = false
2020-02-27 00:41:48 +00:00
resp.Message = fmt.Sprintf("Substitutions failed: %v", failedSubstitutionsErrors)
return resp
2019-08-21 19:38:15 +00:00
}
2020-02-14 19:59:28 +00:00
// Any Pattern validation errors
if len(failedAnyPatternsErrors) > 0 {
var errorStr []string
for _, err := range failedAnyPatternsErrors {
errorStr = append(errorStr, err.Error())
}
resp.Success = false
2020-03-20 18:43:21 +00:00
log.V(4).Info(fmt.Sprintf("Validation rule '%s' failed. %s", rule.Name, errorStr))
if rule.Validation.Message == "" {
resp.Message = fmt.Sprintf("Validation rule '%s' has failed", rule.Name)
} else {
resp.Message = rule.Validation.Message
}
2020-02-14 19:59:28 +00:00
return resp
}
2019-08-21 19:38:15 +00:00
}
return response.RuleResponse{}
}