From de5cd8f60f59f056d38aea297162c179d4fa5fa7 Mon Sep 17 00:00:00 2001
From: Ewout Prangsma <ewout@prangsma.net>
Date: Mon, 9 Jul 2018 13:15:18 +0200
Subject: [PATCH] Review comments

---
 dashboard/src/auth/Login.js                   | 10 +++++-----
 dashboard/src/deployment/DeploymentDetails.js |  2 +-
 dashboard/src/deployment/DeploymentList.js    |  6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/dashboard/src/auth/Login.js b/dashboard/src/auth/Login.js
index 0e8a46fc5..fc3560e30 100644
--- a/dashboard/src/auth/Login.js
+++ b/dashboard/src/auth/Login.js
@@ -1,16 +1,16 @@
 import React, { Component } from 'react';
 import { Button, Container, Form, Icon, Message, Modal } from 'semantic-ui-react';
 
-const LoginView = ({username, password, usernameChanged, passwordChanged, doLogin, error}) => (
+const LoginView = ({username, password, onUsernameChanged, onPasswordChanged, doLogin, error}) => (
   <Container>
     <Form onSubmit={doLogin}>
       <Form.Field>
         <label>Name</label>
-        <input focus="true" value={username} onChange={(e) => usernameChanged(e.target.value)}/>
+        <input focus="true" value={username} onChange={(e) => onUsernameChanged(e.target.value)}/>
       </Form.Field>
       <Form.Field>
         <label>Password</label>
-        <input type="password" value={password} onChange={(e) => passwordChanged(e.target.value)}/>
+        <input type="password" value={password} onChange={(e) => onPasswordChanged(e.target.value)}/>
       </Form.Field>
     </Form>
     {(error) ? <Message error content={error}/> : null}
@@ -36,8 +36,8 @@ class Login extends Component {
             error={this.props.error}
             username={this.state.username}
             password={this.state.password}
-            usernameChanged={(v) => this.setState({username:v})}
-            passwordChanged={(v) => this.setState({password:v})}
+            onUsernameChanged={(v) => this.setState({username:v})}
+            onPasswordChanged={(v) => this.setState({password:v})}
             doLogin={this.handleLogin}
           />
         </Modal.Content>
diff --git a/dashboard/src/deployment/DeploymentDetails.js b/dashboard/src/deployment/DeploymentDetails.js
index bbcbb2fe5..2177af246 100644
--- a/dashboard/src/deployment/DeploymentDetails.js
+++ b/dashboard/src/deployment/DeploymentDetails.js
@@ -19,7 +19,7 @@ const LoaderBox = styled('span')`
 const MemberGroupsView = ({memberGroups, namespace}) => (
   <div>
     {memberGroups.map((item) => <MemberList 
-      key={`server-group-${item.group}`}
+      key={item.group}
       group={item.group}
       members={item.members}
       namespace={namespace}
diff --git a/dashboard/src/deployment/DeploymentList.js b/dashboard/src/deployment/DeploymentList.js
index ef7f45c73..5a7843af9 100644
--- a/dashboard/src/deployment/DeploymentList.js
+++ b/dashboard/src/deployment/DeploymentList.js
@@ -152,8 +152,8 @@ function getStateColorDescription(stateColor) {
 
 class DeploymentList extends Component {
   state = {
-    items: undefined,
-    error: undefined,
+    items: null,
+    error: null,
     loading: true
   };
 
@@ -168,7 +168,7 @@ class DeploymentList extends Component {
       this.setState({
         items: result.deployments,
         loading: false,
-        error: undefined
+        error: null
       });
     } catch (e) {
       this.setState({error: e.message, loading: false});