Building dashboard in docker

Makefile

@@ -72,6 +72,7 @@ endif
 ifndef ENTERPRISEIMAGE
 	ENTERPRISEIMAGE := $(DEFAULTENTERPRISEIMAGE)
 endif
+DASHBOARDBUILDIMAGE := kube-arangodb-dashboard-builder
 
 ifndef ALLOWCHAOS
 	ALLOWCHAOS := true
@@ -111,7 +112,7 @@ build: check-vars docker manifests
 
 .PHONY: clean
 clean:
-	rm -Rf $(BIN) $(BINDIR) $(GOBUILDDIR) $(DASHBOARDDIR)/node_modules
+	rm -Rf $(BIN) $(BINDIR) $(GOBUILDDIR) $(DASHBOARDDIR)/build $(DASHBOARDDIR)/node_modules
 
 .PHONY: check-vars
 check-vars:
@@ -191,11 +192,14 @@ update-generated: $(GOBUILDDIR)
 verify-generated:
 	@${MAKE} -B -s VERIFYARGS=--verify-only update-generated
 
-$(DASHBOARDDIR)/node_modules:
+dashboard/assets.go: $(DASHBOARDSOURCES) $(DASHBOARDDIR)/Dockerfile.build
-	cd $(DASHBOARDDIR) && npm install
+	cd $(DASHBOARDDIR) && docker build -t $(DASHBOARDBUILDIMAGE) -f Dockerfile.build $(DASHBOARDDIR)
-
+	@mkdir -p $(DASHBOARDDIR)/build
-dashboard/assets.go: $(DASHBOARDSOURCES) $(DASHBOARDDIR)/node_modules
+	docker run --rm \
-	cd $(DASHBOARDDIR) && npm run-script build
+		-v $(DASHBOARDDIR)/build:/usr/code/build \
+		-v $(DASHBOARDDIR)/public:/usr/code/public:ro \
+		-v $(DASHBOARDDIR)/src:/usr/code/src:ro \
+		$(DASHBOARDBUILDIMAGE)
 	$(GOASSETSBUILDER) -s /dashboard/build/ -o dashboard/assets.go -p dashboard dashboard/build
 
 $(BIN): $(GOBUILDDIR) $(CACHEVOL) $(SOURCES) dashboard/assets.go

dashboard/.dockerignore

@@ -0,0 +1,8 @@
+/node_modules
+
+# testing
+/coverage
+
+# production
+/build
+

dashboard/Dockerfile.build

@@ -0,0 +1,14 @@
+FROM node:10.6-alpine
+
+RUN mkdir -p /usr/code
+ADD package-lock.json /usr/code/
+ADD package.json /usr/code/
+
+RUN cd /usr/code/ && npm install
+
+VOLUME /usr/code/build
+VOLUME /usr/code/public
+VOLUME /usr/code/src
+
+WORKDIR /usr/code/
+CMD ["npm", "run-script", "build"]