From bc436f3a8fc3c44003ad215e9b103f12cab744b5 Mon Sep 17 00:00:00 2001
From: "Manu [tennox]" <tennox+git@txlab.io>
Date: Sun, 23 Mar 2025 16:28:15 +0545
Subject: [PATCH] zellij: add config options for autostart & completions

---
 modules/lib/maintainers.nix                   |  6 +++
 modules/programs/zellij.nix                   | 47 ++++++++++++++++---
 .../modules/programs/zellij/enable-shells.nix | 14 ++++++
 3 files changed, 60 insertions(+), 7 deletions(-)

diff --git a/modules/lib/maintainers.nix b/modules/lib/maintainers.nix
index 61f3a4f1b..fd97aa71d 100644
--- a/modules/lib/maintainers.nix
+++ b/modules/lib/maintainers.nix
@@ -585,6 +585,12 @@
     keys =
       [{ fingerprint = "75F0 AB7C FE01 D077 AEE6  CAFD 353E 4A18 EE0F AB72"; }];
   };
+  tennox = {
+    name = "Manu";
+    github = "tennox";
+    githubId = 2084639;
+    matrix = "@tennox:matrix.org";
+  };
   tensor5 = {
     github = "tensor5";
     githubId = 1545895;
diff --git a/modules/programs/zellij.nix b/modules/programs/zellij.nix
index 3d5c0dd52..b4155626a 100644
--- a/modules/programs/zellij.nix
+++ b/modules/programs/zellij.nix
@@ -9,7 +9,7 @@ let
   zellijCmd = getExe cfg.package;
 
 in {
-  meta.maintainers = [ hm.maintainers.mainrs ];
+  meta.maintainers = with hm.maintainers; [ mainrs tennox ];
 
   options.programs.zellij = {
     enable = mkEnableOption "zellij";
@@ -47,11 +47,31 @@ in {
     enableBashIntegration =
       lib.hm.shell.mkBashIntegrationOption { inherit config; };
 
-    enableFishIntegration =
-      lib.hm.shell.mkFishIntegrationOption { inherit config; };
+    enableFishIntegration = lib.hm.shell.mkFishIntegrationOption {
+      inherit config;
+      extraDescription =
+        "Enables both enableFishAutoStart and enableFishCompletions";
+    };
 
     enableZshIntegration =
       lib.hm.shell.mkZshIntegrationOption { inherit config; };
+
+    enableFishCompletions = mkEnableOption "load zellij completions" // {
+      default = true;
+    };
+    enableFishAutoStart =
+      mkEnableOption "autostart zellij in interactive sessions" // {
+        default = false;
+      };
+    autoStartAttachIfSessionExists = mkEnableOption
+      "attach to the default session, if a zellij session already exists (otherwise starting a new session)"
+      // {
+        default = false;
+      };
+    autoStartExitShellOnZellijExit =
+      mkEnableOption "exit the shell when zellij exits." // {
+        default = false;
+      };
   };
 
   config = mkIf cfg.enable {
@@ -77,9 +97,22 @@ in {
       eval "$(${zellijCmd} setup --generate-auto-start zsh)"
     '');
 
-    programs.fish.interactiveShellInit = mkIf cfg.enableFishIntegration
-      (mkOrder 200 ''
-        eval (${zellijCmd} setup --generate-auto-start fish | string collect)
-      '');
+    home.sessionVariables = {
+      ZELLIJ_AUTO_ATTACH =
+        if cfg.autoStartAttachIfSessionExists then "true" else "false";
+      ZELLIJ_AUTO_EXIT =
+        if cfg.autoStartExitShellOnZellijExit then "true" else "false";
+    };
+
+    programs.fish.interactiveShellInit = mkIf (cfg.enableFishIntegration
+      || cfg.enableFishAutoStart || cfg.enableFishCompletions) (mkOrder 200
+        ((if cfg.enableFishIntegration || cfg.enableFishCompletions then ''
+          eval (${zellijCmd} setup --generate-completion fish | string collect)
+        '' else
+          "") + (if cfg.enableFishIntegration || cfg.enableFishAutoStart then ''
+            eval (${zellijCmd} setup --generate-auto-start fish | string collect)
+          '' else
+            "")));
+
   };
 }
diff --git a/tests/modules/programs/zellij/enable-shells.nix b/tests/modules/programs/zellij/enable-shells.nix
index 63e13facc..93f3ccce6 100644
--- a/tests/modules/programs/zellij/enable-shells.nix
+++ b/tests/modules/programs/zellij/enable-shells.nix
@@ -7,6 +7,10 @@
       enableBashIntegration = true;
       enableZshIntegration = true;
       enableFishIntegration = true;
+      enableFishAutoStart = true;
+      enableFishCompletions = true;
+      autoStartAttachIfSessionExists = true;
+      autoStartExitShellOnZellijExit = true;
     };
     bash.enable = true;
     zsh.enable = true;
@@ -32,5 +36,15 @@
     assertFileContains \
       home-files/.config/fish/config.fish \
       'eval (@zellij@/bin/zellij setup --generate-auto-start fish | string collect)'
+    assertFileContains \
+      home-files/.config/fish/config.fish \
+      'eval (@zellij@/bin/dummy setup --generate-completion fish | string collect)'
+    assertFileExists home-path/etc/profile.d/hm-session-vars.sh
+    assertFileContains \
+      home-path/etc/profile.d/hm-session-vars.sh \
+      'export ZELLIJ_AUTO_ATTACH="true"'
+    assertFileContains \
+      home-path/etc/profile.d/hm-session-vars.sh \
+      'export ZELLIJ_AUTO_EXIT="true"'
   '';
 }