rclone: correctly escape whitespace in secrets

modules/programs/rclone.nix

@@ -124,7 +124,7 @@ in {
           lib.mapAttrsToList (secret: secretFile: ''
             ${lib.getExe cfg.package} config update \
               ${remote.name} config_refresh_token=false \
-              ${secret} $(cat ${secretFile}) \
+              ${secret} "$(cat ${secretFile})" \
               --quiet > /dev/null
           '') remote.value.secrets or { };
 

tests/integration/standalone/rclone/default.nix

@@ -84,6 +84,20 @@
         ./with-secrets-in-store.conf
       } /home/alice/.config/rclone/rclone.conf")
 
+    with subtest("Secrets with spaces"):
+      succeed_as_alice("install -m644 ${
+        ./secrets-with-whitespace.nix
+      } /home/alice/.config/home-manager/test-remote.nix")
+
+      actual = succeed_as_alice("home-manager switch")
+      expected = "Activating createRcloneConfig"
+      assert expected in actual, \
+        f"expected home-manager switch to contain {expected}, but got {actual}"
+
+      succeed_as_alice("diff -u ${
+        ./secrets-with-whitespace.conf
+      } /home/alice/.config/rclone/rclone.conf")
+
     # TODO: verify correct activation order with the agenix and sops hm modules
 
     logout_alice()

tests/integration/standalone/rclone/secrets-with-whitespace.conf

@@ -0,0 +1,5 @@
+[alices-cool-remote-v3]
+description = alices speeedy remote
+type = memory
+spaces-secret = This is a secret with spaces, it has single spaces,                  and lots of spaces :3
+

tests/integration/standalone/rclone/secrets-with-whitespace.nix

@@ -0,0 +1,13 @@
+{ pkgs, ... }: {
+  programs.rclone.remotes = {
+    alices-cool-remote-v3 = {
+      config = {
+        type = "memory";
+        description = "alices speeedy remote";
+      };
+      secrets.spaces-secret = "${pkgs.writeText "secret" ''
+        This is a secret with spaces, it has single spaces,                  and lots of spaces :3
+      ''}";
+    };
+  };
+}