mirrors/home-manager
1
0
Fork 0
mirror of https://github.com/nix-community/home-manager.git synced 2024-12-14 11:57:55 +00:00
Code Activity
home-manager/.github/PULL_REQUEST_TEMPLATE.md

50 lines
1.4 KiB
Markdown
Raw Normal View History

doc: add contribution guidelines section This adds a section in the documentation for describing a list of guidelines that code in Home Manager should follow. This also updates the pull request template to reference this new section.
2020-05-23 12:07:19 +00:00
### Description
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
<!--
doc: add contribution guidelines section This adds a section in the documentation for describing a list of guidelines that code in Home Manager should follow. This also updates the pull request template to reference this new section.
2020-05-23 12:07:19 +00:00
Please provide a brief description of your change.
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
-->
doc: add contribution guidelines section This adds a section in the documentation for describing a list of guidelines that code in Home Manager should follow. This also updates the pull request template to reference this new section.
2020-05-23 12:07:19 +00:00
### Checklist
<!--
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
doc: add contribution guidelines section This adds a section in the documentation for describing a list of guidelines that code in Home Manager should follow. This also updates the pull request template to reference this new section.
2020-05-23 12:07:19 +00:00
Please go through the following checklist before opening a non-WIP
pull-request.
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
doc: add contribution guidelines section This adds a section in the documentation for describing a list of guidelines that code in Home Manager should follow. This also updates the pull request template to reference this new section.
2020-05-23 12:07:19 +00:00
Also make sure to read the guidelines found at
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
docs: rename "doc" directory to "docs" Also remove `CONTRIBUTING.adoc` and `FAQ.adoc` from project root since GitHub knows to pick them up from the docs directory. Fixes #2273
2021-08-17 17:28:04 +00:00
https://github.com/nix-community/home-manager/blob/master/docs/contributing.adoc#sec-guidelines
doc: add contribution guidelines section This adds a section in the documentation for describing a list of guidelines that code in Home Manager should follow. This also updates the pull request template to reference this new section.
2020-05-23 12:07:19 +00:00
-->
- [ ] Change is backwards compatible.
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
- [ ] Code formatted with `./format`.
PR_TEMPLATE: Note nix3 test method in checklist (#3972) * PR_TEMPLATE: Note nix3 test method in checklist Allows for running with the `nixpkgs` from the lock file, as well as using a more familiar interface for users of the experimental CLI, which would've avoided me opening #3971. Also updates the corresponding note in `docs/contributing.adoc` to have the correct invocation path. * PR_TEMPLATE: `the experimental CLI` -> `Flakes`
2023-05-17 10:59:35 +00:00
- [ ] Code tested through `nix-shell --pure tests -A run.all` or `nix develop --ignore-environment .#all` using Flakes.
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
tree-wide: update url to the repo
2020-10-19 19:20:37 +00:00
- [ ] Test cases updated/added. See [example](https://github.com/nix-community/home-manager/commit/f3fbb50b68df20da47f9b0def5607857fcc0d021#diff-b61a6d542f9036550ba9c401c80f00ef).
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
- [ ] Commit messages are formatted like
```
{component}: {description}
{long description}
```
docs: rename "doc" directory to "docs" Also remove `CONTRIBUTING.adoc` and `FAQ.adoc` from project root since GitHub knows to pick them up from the docs directory. Fixes #2273
2021-08-17 17:28:04 +00:00
See [CONTRIBUTING](https://github.com/nix-community/home-manager/blob/master/docs/contributing.adoc#sec-commit-style) for more information and [recent commit messages](https://github.com/nix-community/home-manager/commits/master) for examples.
Add code owners and pull request template
2020-04-08 17:22:36 +00:00
- If this PR adds a new module
tree-wide: update url to the repo
2020-10-19 19:20:37 +00:00
- [ ] Added myself as module maintainer. See [example](https://github.com/nix-community/home-manager/blob/068ff76a10e95820f886ac46957edcff4e44621d/modules/programs/lesspipe.nix#L6).
PULL_REQUEST_TEMPLATE.md: add maintainer cc section (#4193)
2023-07-04 10:41:04 +00:00
#### Maintainer CC
<!--
If you are updating a module, please @ people who are in its `meta.maintainers` list.
If in doubt, check `git blame` for whoever last touched something.
-->
Copy permalink