mirrors/external-secrets
1
0
Fork 0
mirror of https://github.com/external-secrets/external-secrets.git synced 2024-12-14 11:57:59 +00:00
Code Activity
3155 commits 135 branches 173 tags 201 MiB
Commit graph

215 commits

Author SHA1 Message Date
Romain DARY
d424b6ff70 chore: improve external secret reconciliation sequence 
Secret client is created only if we are going to refresh
this skip an unnecessary check/request in the case we are not going to do anything
 2022-04-27 12:34:48 +02:00
Gustavo Carvalho
6a67f5c435 Checking if condition is not nil before using it. 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-04-18 08:19:47 -03:00
Merlin
4820cc9165 Ignore ExternalSecret processing if the store is not usuable (e.g. 
NotReady).
 2022-04-13 23:24:39 +02:00
Gustavo Carvalho
4d2dc2c34c Adding owner reference to the external secret name, instead of to a generic 'external-secrets' name 
Fixes #918

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-04-08 10:42:18 -03:00
Moritz Johner
c2bcceb057
feat: implement deletionPolicy (#900) 
* feat: implement deletionPolicy

Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
Co-authored-by: Gustavo Fernandes de Carvalho <gustavo.carvalho@container-solutions.com>
 2022-04-05 13:38:06 +02:00
Merlin
2d988b9497 fix: use controller-runtime internal backoff retry instead of explicitly ask a fixed retry 2022-04-04 11:22:01 +02:00
Sebastián Gómez
b1a240db6f Fixed lint issue 2022-03-25 16:48:08 -04:00
Sebastián Gómez
3cfb9ba2c1 Merge from main 2022-03-25 16:32:45 -04:00
Sebastián Gómez
3b6c6ca09a Fixed some masked error and avoided panics 2022-03-25 16:17:18 -04:00
Eric Chan
4055e7d186 refactor and add unit test for skipping cluster secret store 2022-03-24 23:55:06 +10:00
Eric Chan
da6e457b50 skip processing cluster secret store 2022-03-24 23:55:00 +10:00
Gustavo Carvalho
bae43b39c4 Adding mutexes only for GCP provider 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-03-24 06:34:07 -03:00
Daniel Hix
324c7def06
feat: implement ClusterExternalSecret (#542) 
Co-authored-by: Gustavo Fernandes de Carvalho <gusfcarvalho@gmail.com>
 2022-03-20 09:32:27 +01:00
Gustavo Carvalho
164e8776ec Adding docs and implementing ConversionStrategy 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-03-09 06:59:54 -03:00
paul-the-alien[bot]
b9de64b967
Merge pull request #750 from external-secrets/feature/validating-webhook 
Feature: validating webhook
 2022-03-02 17:10:56 +00:00
Moritz Johner
8fc4484cc6 feat: implement validating webhook 
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-03-01 21:25:15 +01:00
Marc Billow
6de9399126 Fix template fallback logic to handle TemplateFrom syntax 2022-02-23 16:34:50 -06:00
Gustavo Carvalho
847b95e4fd Merge branch 'main' into feature/conversion-webhook 
Disabled secrets cache for cert controller.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-17 09:35:20 -03:00
paul-the-alien[bot]
4cca87b6d7
Merge pull request #729 from external-secrets/fix/disable-sec-cm-cache 
feat: avoid caching secrets/configmaps
 2022-02-17 09:15:31 +00:00
Gustavo Carvalho
40ec693479 Merge branch 'main' into feature/conversion-webhook 
Fixed conflicts and implemented necessary changes for v1beta1
 2022-02-16 16:00:32 -03:00
Moritz Johner
899cf72f22 feat: avoid caching secrets/configmaps 
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-02-16 14:37:42 +01:00
Gustavo Carvalho
96cb340ace Implementing Requeue Interval for certController. Fixing unit tests and check-diff 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-14 16:05:17 -03:00
Gustavo Carvalho
1d8cfc4a12 Changed logic of Webhook check for certs. 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-14 15:46:10 -03:00
Gustavo Carvalho
31eedfbb26 Fixing up some code smells 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-14 10:36:12 -03:00
Gustavo Carvalho
1587fa02b1 Improved deployments and crd logic. Added cert-controller reconcile tests 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-14 10:08:27 -03:00
Gustavo Carvalho
3d9e5a9fdb Adding controller tests for cert-controller 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-14 09:01:21 -03:00
Gustavo Carvalho
e776f6d843 WIP: implementing separate deployments 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-13 09:14:41 -03:00
Gustavo Carvalho
ab03bcdcc7 Making reviewable 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-11 15:17:20 -03:00
Gustavo Carvalho
a85e487d1d Added unit tests for crd controller methods. 
Added simple GetAllSecrets logic test
Starting (and failing to) test on controller level

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-11 15:14:14 -03:00
Gustavo Carvalho
024b64fe39 Added Readiness Probe for helm charts. 
Fixed make generate command to not use kubectl
Fixed lint

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-11 08:10:11 -03:00
Moritz Johner
54e68399ec feat: implement template engine v2 
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-02-11 08:26:31 +01:00
Gustavo Carvalho
fd9e09a1ee WIP: Structured reconciliation loops for CRDs 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-10 14:12:13 -03:00
Gustavo Carvalho
0530385992 v1beta1 initial commit 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2022-02-08 14:07:34 -03:00
Lucas Severo Alves
6630ab7494
Initial draft of reporter (#466) 
* Initial draft of reporter

* Test out reporter in AWS provider

* trying out different events approach

* feat: implement store reconciler and events

Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>

* feat: add validate() method to provider interface

Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>

* fix: use static requeue interval in store ctrl

Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>

Co-authored-by: Mircea Cosbuc <mircea.cosbuc@container-solutions.com>
Co-authored-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-02-07 11:42:18 +01:00
Moritz Johner
fe1cb8bc69 feat(provider): implement fake provider 
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-02-01 11:18:43 +01:00
Moritz Johner
e015bed08d chore: update k8s / envtest 2022-01-28 19:51:07 +01:00
paul-the-alien[bot]
6f4c03a75d
Merge pull request #645 from external-secrets/fix/delete-secret-using-tpl 
fix: ensure that data is being deleted when using tpl
 2022-01-27 14:49:00 +00:00
Jeroen Op 't Eynde
83afebe9b3
fix(metrics): ensure status_condition metrics reflect the status (#612) 
* fix(metrics): ensure status_condition metrics reflect the status

* lint fixes

* fix(metrics): remove condition=deleted metric (+lint fixes)
 2022-01-27 14:26:09 +01:00
Moritz Johner
e2701fa35a fix: ensure that data is being deleted when using tpl 2022-01-26 20:14:59 +01:00
paul-the-alien[bot]
0b9c142a22
Merge pull request #618 from external-secrets/feature/aws-e2e-managed 
feat(e2e): implement aws tests, enhance gcp tests
 2022-01-24 10:46:02 +00:00
Moritz Johner
008268ee00 feat(e2e): implement aws tests, enhance gcp tests 
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-01-21 23:37:50 +01:00
Marc Ingram
07415bdabf improve test? 2022-01-21 14:01:45 -07:00
Marc Ingram
e93a1716f5 fix format and lint 2022-01-21 13:36:41 -07:00
Marc Ingram
705ffbbd95 Optimise patching so as changes only happen with something changes 2022-01-21 12:36:05 -07:00
Moritz Johner
27854adaa5 fix: force ownership when merging secrets 
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
 2022-01-14 22:27:27 +01:00
Jack Evans
d77f543c98
add concurrent flag to allow more reconciles at the same time 2021-12-17 15:36:51 +00:00
paul-the-alien[bot]
0fb03e4650
Merge pull request #450 from external-secrets/feature/log-on-success 
Added log for first secret reconciliation after errors
 2021-11-02 23:34:57 +00:00
paul-the-alien[bot]
cc79b7b615
Merge pull request #422 from FGA-GCES/eduardo/code_smells 
Fixing some codeSmells
 2021-11-02 23:04:05 +00:00
Eduardo Vieira
1742b9c9fc Adjsuting lint 2021-11-02 18:30:39 -03:00
Gustavo Carvalho
03afd1099c Adding inline comments explaining log functionality 
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
 2021-11-01 17:53:59 -03:00
Gustavo Fernandes de Carvalho
b8ba78d1b1 Added log for first secret reconciliation after errors 
Fixes #444

Signed-off-by: Gustavo Fernandes de Carvalho <gustavo.carvalho@container-solutions.com>
 2021-10-25 16:29:22 -03:00
Eduardo Lima
ff90d4eb44
Removing "map" from test const name 2021-10-21 14:46:47 -03:00
Lucas Severo Alves
c00afc9ff7
Merge pull request #329 from FGA-GCES/feat/immutable-secrets 
Add immutable secrets
 2021-10-12 18:20:23 +02:00
Eduardo Vieira
c68e00ce0c Creating map-foo and bar const for testing 2021-10-07 10:55:04 -03:00
Eduardo Vieira
b2b6b5255d Defining targetProp const for reutilization 2021-10-07 10:50:27 -03:00
Eduardo Vieira
3d5c0b54e6 Changing expectedSecretValue declaration scope 2021-10-07 10:43:59 -03:00
Eduardo Vieira
7502e2c557 Adding FakeManager and test-secret const for testing 2021-10-07 10:39:13 -03:00
Arthur
0990f29876 Merge branch 'feat/immutable-secrets' of github.com:FGA-GCES/external-secrets into feat/immutable-secrets 2021-10-06 21:24:50 -03:00
Arthur
1f5978eb13 add tests for controller reconciling logic 2021-10-06 21:23:41 -03:00
Mateus Oliveira Patrício
b16d4389b9 refactor: remove unnecessary convert 2021-09-22 23:57:36 +02:00
Mateus Oliveira Patrício
b2adb77f1b fix: syncWithoutTargetName test case 2021-09-22 23:57:36 +02:00
Mateus Oliveira Patrício
42a658c2b1 WiP: no target name unit test 2021-09-22 23:57:36 +02:00
Arthur
9f2a17f220 Merge branch 'main' into feat/immutable-secrets 2021-09-22 14:20:35 -03:00
Arthur
4de31e9d4d stopping reconciling for immutable secrets based on es conditions 2021-09-17 21:37:21 -03:00
Moritz Johner
ce02f98db9 fix: add explicit test for using dataFrom + template 2021-09-10 16:07:39 +02:00
Alexander Chernov
280964f84e
fix: dependent kind=secret are not recreated in case of deletion. (#349) 
* chore: whitespace, typos, superflous aliases

* fix: deleted child secret is not recreated straight away.

* fix: e2e run
 2021-09-09 11:14:17 +02:00
Arthur
8417b34d26 make reconciling stop if es is synced and immutable 2021-09-08 20:44:23 -03:00
Moritz Johner
059c54bc53 fix: allow using tpl metadata 2021-09-02 18:14:03 +02:00
Arthur
e32353c8a4 fixing tests for immutable secret 2021-08-26 15:05:15 -03:00
zamysel
0dc8842b85 Merge branch 'main' into lockbox 2021-08-25 11:23:15 +03:00
paul-the-alien[bot]
201e43f4af
Merge pull request #327 from spirosoik/fix/iss-315 
Fix the issue for non deleting one/more key-value pair
 2021-08-20 15:26:37 +00:00
Mateus Oliveira Patrício
6655ed120e fix: use es name if target secret is empty 2021-08-19 18:43:34 -03:00
Arthur
c8315865a1 add immutable field on ExternalSecretTarget and on v1.Secret creation 
Co-authored-by: mouhsen-ibrahim <mouhsen.ibrahim@gmail.com>
 2021-08-18 19:55:10 -03:00
Spiros Economakis
73ec3a5368
Fix the issue for non deleting one/more key-value pair 
The issue is that the `dataMap` from the provider returns only the remaining data
and we were updating partially the current `secretMap` only for the keys included
in the new value.

Ticket: #315
 2021-08-18 14:30:20 +03:00
zamysel
7017935888 Add support for Yandex Lockbox 2021-08-12 20:05:02 +03:00
Spiros Economakis
f1829f0445
Set the metric when is deleted to condition deleted and false (#306) 
* Set the metric when is deleted to condition deleted and false

When a metrics is deleted metrics are still shown ready and condition true.
In practice this gives the wrong monitoring as the external secret in practice
is deleted.

Issue: #231

* Fix name and namespace for the metric of deletion
 2021-08-07 23:40:26 +02:00
Moritz Johner
49fbf72bf6 fix: zero refreshInterval shouldn't sync 2021-08-02 22:48:13 +02:00
Moritz Johner
8e61b49c82 fix: resource leak 2021-07-28 09:45:25 +02:00
Moritz Johner
59a851c941 feat(ctrl): implement creationPolicy=Merge/None 2021-07-12 18:45:44 +02:00
Moritz Johner
6d2f3dd7b1 fix(template): fix templateFrom tpl execution 2021-07-10 17:51:16 +02:00
Moritz Johner
73ca014cfb feat: implement templateFrom 2021-06-28 21:29:09 +02:00
paul-the-alien[bot]
f4dd6d547a
Merge pull request #217 from ContainerSolutions/gcp_property 
feat: add property feature to gcp
 2021-06-25 21:46:49 +00:00
Moritz Johner
5ac02ed2c4 feat: add synced resource version status 2021-06-25 21:23:29 +02:00
Lucas Severo Alves
01267ea6aa fix: close method for conections that need closing 2021-06-25 16:13:02 +02:00
Elsa Chelala
30d2c8648c Added changes to the Reconcile function documentation 2021-06-23 09:36:37 -04:00
Elsa Chelala
776ef0d27b dded doc strings and comments for the controllers package 2021-06-21 13:12:06 -04:00
Moritz Johner
7f07c712ac chore: refactor es ctrl tests 2021-05-23 13:41:42 +02:00
Moritz Johner
e5d6e30d00 fix: template data should be string, fix update mechanics 2021-05-20 08:46:22 +02:00
Moritz Johner
6b14f3ac03 fix: ensure condition errors do not change with every req 2021-05-03 22:29:26 +02:00
Moritz Johner
f49de4f887 fix: update condition when error message changes 
fixes #116
 2021-05-03 22:28:19 +02:00
paul-the-alien[bot]
4de378f939
Merge pull request #120 from external-secrets/feat/e2e-tests 
feat: e2e tests
 2021-04-28 15:57:39 +00:00
paul-the-alien[bot]
682edff175
Merge pull request #119 from cnmcavoy/cnmcavoy/vault-cluster-secret-store 
Add support for cluster secret store with the vault provider
 2021-04-27 15:49:49 +00:00
Moritz Johner
3d53b64303 fix: metrics tests 2021-04-25 16:29:25 +02:00
Moritz Johner
8c8064e0e1
Draft: feat: implement template (#69) 
* feat: implement template
 2021-04-23 08:22:23 +02:00
Jonatas Baldin
b8fda4387d
Merge pull request #110 from external-secrets/metrics-first-iteration 
Add first iteration of custom metrics
 2021-04-22 18:35:35 +02:00
Cameron McAvoy
4d3faf70a1 Add support for cluster secret store with the vault provider 2021-04-20 18:47:28 -05:00
Jonatas Baldin
8eb569fc92 Remove uneceassary comment 2021-04-15 12:00:06 +02:00
Jonatas Baldin
866411997a Fix flaky tests (I hope!) 2021-04-14 17:18:14 +02:00
Jonatas Baldin
be51883506 Fix lint errors 2021-04-14 17:02:02 +02:00
Jonatas Baldin
90137df9a0 Remove controller predicate, add externalSecretCondition metric 2021-04-14 16:51:31 +02:00
Jonatas Baldin
07e81f262c Fix "File is not gci-ed" lint error 2021-04-12 17:51:51 +02:00
Jonatas Baldin
d7fced6310 Rename sync_calls_total and sync_calls_error variables to adhere coding style 2021-04-12 17:23:41 +02:00
Jonatas Baldin
80f6376d2c Add first iteration of custom metrics 2021-04-12 17:07:43 +02:00
Kellin McAvoy
6318811108 Cleanup and remove kustomize manifests in favor of Helm chart 2021-04-08 13:56:11 -05:00
Moritz Johner
640978ca9e
feat: awssm refactoring (#57) 
* fix: refactor awssm provider
 2021-03-10 11:43:25 +01:00
Moritz Johner
ad686d4b50
feat: refactor provider / secretsclient interface (#55) 
* feat: refactor provider / secretsclient interface

see #53
 2021-03-08 14:20:58 +01:00
Moritz Johner
a017255464
fix: validate refresh interval, refresh externalsecret (#48) 
* fix: refresh es
 2021-03-05 23:58:08 +01:00
Moritz Johner
53cc579ee8
fix: ssm may respond with nil SecretString (#41) 
also: support nested json keys like foo.bar
details here: https://github.com/tidwall/gjson
 2021-02-26 09:11:16 +01:00
Moritz Johner
92be45df6a
add awssm support (#34) 
* feat: add awssm

fixes #26
 2021-02-24 20:01:28 +01:00
Moritz Johner
89c56c269f
feat: status conditions (#25) 
* feat: implement es ready condition

Co-authored-by: Kellin <kellinmcavoy@gmail.com>
 2021-02-15 21:51:38 +01:00
Moritz Johner
adb4de943d chore: update dependencies 2021-02-06 13:16:36 +01:00
Lucas Severo Alves
60aaecf76b Linter fixes 2021-01-27 12:44:25 +01:00
Lucas Severo Alves
04f3dd4119 Merge branch 'main' into add-main-controller-logic 2021-01-27 12:18:11 +01:00
Lucas Severo Alves
3227e730f1 Change dir structure and adapt 2021-01-27 12:08:28 +01:00
Kellin McAvoy
3fd7586033 move controller into pkg 2021-01-07 12:50:59 -05:00