mirrors/external-secrets
1
0
Fork 0
mirror of https://github.com/external-secrets/external-secrets.git synced 2024-12-14 11:57:59 +00:00
Code Activity

fix: bitwarden API url to point to the correct default location (#3848)

Browse source 
* fix: bitwarden API url to point to the correct default location

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* explicitly remove trailing slashes to prevent not found error

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
This commit is contained in:
Gergely Brautigam 2024-09-02 07:04:48 +02:00 committed by GitHub
parent 1309c2c41b
commit c3dcd9adcd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/snippets/bitwarden-secrets-manager-secret-store.yaml
View file

@ -5,7 +5,7 @@ metadata:
spec: spec:
provider: provider:
bitwardensecretsmanager: bitwardensecretsmanager:
apiURL: https://vault.bitwarden.com apiURL: https://api.bitwarden.com
identityURL: https://identity.bitwarden.com identityURL: https://identity.bitwarden.com
auth: auth:
secretRef: secretRef:

5
pkg/provider/bitwarden/bitwarden_sdk.go
View file

@ -21,6 +21,7 @@ import (
"fmt" "fmt"
"io" "io"
"net/http" "net/http"
"strings"
"sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/client"
@ -111,8 +112,8 @@ func NewSdkClient(ctx context.Context, c client.Client, storeKind, namespace str
} }
return &SdkClient{ return &SdkClient{
apiURL: provider.APIURL, apiURL: strings.TrimSuffix(provider.APIURL, "/"),
identityURL: provider.IdentityURL, identityURL: strings.TrimSuffix(provider.IdentityURL, "/"),
bitwardenSdkServerURL: provider.BitwardenServerSDKURL, bitwardenSdkServerURL: provider.BitwardenServerSDKURL,
token: token, token: token,
client: httpsClient, client: httpsClient,