1
0
Fork 0
mirror of https://github.com/external-secrets/external-secrets.git synced 2024-12-14 11:57:59 +00:00

fix: handle empty template engine version (#4182)

This commit is contained in:
Mathew Wicks 2024-12-06 23:59:10 -08:00 committed by GitHub
parent 2d5829b790
commit bece0ec257
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -27,7 +27,10 @@ type ExecFunc func(tpl, data map[string][]byte, scope esapi.TemplateScope, targe
func EngineForVersion(version esapi.TemplateEngineVersion) (ExecFunc, error) { func EngineForVersion(version esapi.TemplateEngineVersion) (ExecFunc, error) {
switch version { switch version {
case esapi.TemplateEngineV1: // NOTE: the version can be empty if the ExternalSecret was created with version 0.4.3 or earlier,
// all versions after this will default to "v1" (for v1alpha1 ES) or "v2" (for v1beta1 ES).
// so if we encounter an empty version, we must default to the v1 engine.
case esapi.TemplateEngineV1, "":
return v1.Execute, nil return v1.Execute, nil
case esapi.TemplateEngineV2: case esapi.TemplateEngineV2:
return v2.Execute, nil return v2.Execute, nil