mirrors/external-secrets
1
0
Fork 0
mirror of https://github.com/external-secrets/external-secrets.git synced 2024-12-14 11:57:59 +00:00
Code Activity

fix: make vault provider return NoSecretErr to respect deletionPolicy (#2455)

Browse source 
relates to #1512 #1502

Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
This commit is contained in:
Moritz Johner 2023-07-06 08:22:34 +02:00 committed by GitHub
parent 45aa382fc5
commit 69fe93ea49
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/provider/vault/vault.go
View file

@ -707,7 +707,7 @@ func (v *client) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretData
// Return nil if secret value is null
if data == nil {
return nil, nil
return nil, esv1beta1.NoSecretError{}
}
jsonStr, err := json.Marshal(data)
if err != nil {

16
pkg/provider/vault/vault_test.go
View file

@ -632,6 +632,22 @@ func TestGetSecret(t *testing.T) {
val: []byte("something different"),
},
},
"ReadSecretWithMissingValueFromData": {
reason: "Should return a NoSecretErr",
args: args{
store: makeValidSecretStoreWithVersion(esv1beta1.VaultKVStoreV1).Spec.Provider.Vault,
data: esv1beta1.ExternalSecretDataRemoteRef{
Property: "not-relevant",
},
vLogical: &fake.Logical{
ReadWithDataWithContextFn: fake.NewReadWithContextFn(nil, nil),
},
},
want: want{
err: esv1beta1.NoSecretErr,
val: nil,
},
},
"ReadSecretWithSliceValue": {
reason: "Should return property as a joined slice",
args: args{