mirrors/external-secrets
1
0
Fork 0
mirror of https://github.com/external-secrets/external-secrets.git synced 2024-12-14 11:57:59 +00:00
Code Activity

Validator (#3003)

Browse source 
* feat: add validator for duplicates keys

Signed-off-by: Mehrbod Akhlaghpour <m9.akhlaghpoor@gmail.com>

* feat: retain mode on duplicate keys

Signed-off-by: Mehrbod Akhlaghpour <m9.akhlaghpoor@gmail.com>

* feat: add new test

Signed-off-by: Mehrbod Akhlaghpour <m9.akhlaghpoor@gmail.com>

* chore: rebase the test

Signed-off-by: Mehrbod Akhlaghpour <m9.akhlaghpoor@gmail.com>

* fix: test cases for duplicate keys

Signed-off-by: Mehrbod Akhlaghpour <m9.akhlaghpoor@gmail.com>

---------

Signed-off-by: Mehrbod Akhlaghpour <m9.akhlaghpoor@gmail.com>
This commit is contained in:
Amirhossein Akhlaghpour 2024-01-14 20:38:59 +03:30 committed by GitHub
parent 1f665cea5d
commit 1bd07fd90e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 48 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
apis/externalsecrets/v1beta1/externalsecret_validator.go
View file

@ -63,5 +63,20 @@ func validateExternalSecret(obj runtime.Object) (admission.Warnings, error) {
} }
} }
errs = validateDuplicateKeys(es, errs)
return nil, errs return nil, errs
} }
func validateDuplicateKeys(es *ExternalSecret, errs error) error {
if es.Spec.Target.DeletionPolicy == DeletionPolicyRetain {
seenKeys := make(map[string]struct{})
for _, data := range es.Spec.Data {
secretKey := data.SecretKey
if _, exists := seenKeys[secretKey]; exists {
errs = errors.Join(errs, fmt.Errorf("duplicate secretKey found: %s", secretKey))
}
seenKeys[secretKey] = struct{}{}
}
}
return errs
}

33
apis/externalsecrets/v1beta1/externalsecret_validator_test.go
View file

@ -122,6 +122,39 @@ either data or dataFrom should be specified`,
}, },
}, },
}, },
{
name: "duplicate secretKeys",
obj: &ExternalSecret{
Spec: ExternalSecretSpec{
Target: ExternalSecretTarget{
DeletionPolicy: DeletionPolicyRetain,
},
Data: []ExternalSecretData{
{SecretKey: "SERVICE_NAME"},
{SecretKey: "SERVICE_NAME"},
{SecretKey: "SERVICE_NAME-2"},
{SecretKey: "SERVICE_NAME-2"},
{SecretKey: "NOT_DUPLICATE"},
},
},
},
expectedErr: "duplicate secretKey found: SERVICE_NAME\nduplicate secretKey found: SERVICE_NAME-2",
},
{
name: "duplicate secretKey",
obj: &ExternalSecret{
Spec: ExternalSecretSpec{
Target: ExternalSecretTarget{
DeletionPolicy: DeletionPolicyRetain,
},
Data: []ExternalSecretData{
{SecretKey: "SERVICE_NAME"},
{SecretKey: "SERVICE_NAME"},
},
},
},
expectedErr: "duplicate secretKey found: SERVICE_NAME",
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {