EvictObjects is trigerred when Dragonfly uses more memory than it is supposed to.
However, it decreases the quality of the original eviction policy, and since
Dragonfly does not use much memory than required, I decided to disable it.
A regular eviction policy (DashCache) was not changed.
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
fix(server): Fix a bug when an expired transaction stays in watched queue.
Now we remove the transaction from the watched queues in a consistent manner based on the
keys it was assigned to watch.
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Fixed stats accounting. Now loop_serialized + side_saved should correspond to number of saved items in a shard.
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This happens when the last argument is a number because SNPrintF makes sure
to write \0 even though we did not account of that when passing capacity.
Since we allocate more than we use, the only thing we need to do is
to pass larger capacity.
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
1. Align checked version with the format provided by the endpoint
2. Improve error reporting as well as install ca certificates in the docker file.
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
* feat(tools):cache log player batching all the way optimization
Signed-off-by: ashotland <ashotland@gmail.com>
* feat(tools): cache log player add one last print stats after completion
Signed-off-by: ashotland <ashotland@gmail.com>
Signed-off-by: ashotland <ashotland@gmail.com>
This should greatly improve readability of the chart itself
- moved the `Pod` spec for both the `Deployment` and `StatefulSet` into a common template in `_pod.yaml`
- replace a bunch of `if $value; print $value`-type blocks with `with $value; print .`
- replaced `command.set` in `values.yaml` with `command` directly
- this was broken anyways, as the chart wrongly referenced `command.cmd` for both `Deployment` and `StatefulSet`
- populated contrib/charts/dragonfly/ci/ folder for development/CI purposes
Signed-off-by: Philipp Born <git@pborn.eu>
Signed-off-by: Philipp Born <git@pborn.eu>
feat(tools):cache log player batching all the way optimization
Signed-off-by: ashotland <ashotland@gmail.com>
Signed-off-by: ashotland <ashotland@gmail.com>
Clarify docker command for macOS
I had issues when running the command on my m2 macbook air. [It turns
out][1] that apparently docker desktop on macOS doesn't really support
the host option.
Additionally, it looks like I had to explicitly pass the port mapping
options for the ports to be actually mapped.
There might be a better and more efficient solution, but this is what I
came up with and it finally worked.
[1]:https://github.com/docker/for-mac/issues/1031
