mirrors/dragonflydb-dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2024-12-14 11:58:02 +00:00
Code Activity

fix(pytests): replace proc.wait() with proc.communicate() to avoid deadlocks (#2964)

Browse source 
* replace proc.wait() with proc.communicate() to avoid deadlocks
This commit is contained in:
Kostas Kyrimis 2024-04-26 13:22:33 +03:00 committed by GitHub
parent 82dd05fe30
commit bbe6c8579a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/dragonfly/instance.py
View file

@ -169,8 +169,7 @@ class DflyInstance:
proc.kill()
else:
proc.terminate()
if proc.wait(timeout=15) < 0 and not kill:
raise Exception("Dragfonfly did not terminate gracefully")
proc.communicate(timeout=15)
except subprocess.TimeoutExpired:
# We need to send SIGUSR1 to DF such that it prints the stacktrace