mirrors/dragonflydb-dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2024-12-14 11:58:02 +00:00
Code Activity

Implement SETEX command

Browse source
This commit is contained in:
Roman Gershman 2022-03-07 23:11:43 +02:00
parent 3c1b600e79
commit abec283247
3 changed files with 31 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -146,6 +146,8 @@ API 2.0
- [X] BLPOP
- [ ] BRPOP
- [ ] BRPOPLPUSH
- [X] String Family
- [X] SETEX
- [X] HashSet Family
- [X] HSET
- [X] HMSET

31
src/server/string_family.cc
View file

@ -97,8 +97,8 @@ OpResult<void> SetCmd::Set(const SetParams& params, std::string_view key, std::s
void StringFamily::Set(CmdArgList args, ConnectionContext* cntx) {
set_qps.Inc();
std::string_view key = ArgS(args, 1);
std::string_view value = ArgS(args, 2);
string_view key = ArgS(args, 1);
string_view value = ArgS(args, 2);
VLOG(2) << "Set " << key << " " << value;
SetCmd::SetParams sparams{cntx->db_index()};
@ -110,7 +110,7 @@ void StringFamily::Set(CmdArgList args, ConnectionContext* cntx) {
for (size_t i = 3; i < args.size(); ++i) {
ToUpper(&args[i]);
std::string_view cur_arg = ArgS(args, i);
string_view cur_arg = ArgS(args, i);
if (cur_arg == "EX" || cur_arg == "PX") {
bool is_ms = (cur_arg == "PX");
@ -164,6 +164,30 @@ void StringFamily::Set(CmdArgList args, ConnectionContext* cntx) {
return builder->SendSetSkipped();
}
void StringFamily::SetEx(CmdArgList args, ConnectionContext* cntx) {
string_view key = ArgS(args, 1);
string_view ex = ArgS(args, 2);
string_view value = ArgS(args, 3);
uint32_t secs;
if (!absl::SimpleAtoi(ex, &secs)) {
return (*cntx)->SendError(kInvalidIntErr);
}
SetCmd::SetParams sparams{cntx->db_index()};
sparams.expire_after_ms = uint64_t(secs) * 1000;
auto cb = [&](Transaction* t, EngineShard* shard) {
SetCmd sg(&shard->db_slice());
auto status = sg.Set(sparams, key, value).status();
return status;
};
OpResult<void> result = cntx->transaction->ScheduleSingleHop(std::move(cb));
return (*cntx)->SendError(result.status());
}
void StringFamily::Get(CmdArgList args, ConnectionContext* cntx) {
get_qps.Inc();
@ -545,6 +569,7 @@ void StringFamily::Shutdown() {
void StringFamily::Register(CommandRegistry* registry) {
*registry << CI{"SET", CO::WRITE | CO::DENYOOM, -3, 1, 1, 1}.HFUNC(Set)
<< CI{"SETEX", CO::WRITE | CO::DENYOOM, 4, 1, 1, 1}.HFUNC(SetEx)
<< CI{"APPEND", CO::WRITE | CO::FAST, 3, 1, 1, 1}.HFUNC(Append)
<< CI{"PREPEND", CO::WRITE | CO::FAST, 3, 1, 1, 1}.HFUNC(Prepend)
<< CI{"INCR", CO::WRITE | CO::DENYOOM | CO::FAST, 2, 1, 1, 1}.HFUNC(Incr)

1
src/server/string_family.h
View file

@ -50,6 +50,7 @@ class StringFamily {
private:
static void Set(CmdArgList args, ConnectionContext* cntx);
static void SetEx(CmdArgList args, ConnectionContext* cntx);
static void Get(CmdArgList args, ConnectionContext* cntx);
static void GetSet(CmdArgList args, ConnectionContext* cntx);
static void MGet(CmdArgList args, ConnectionContext* cntx);