mirrors/dragonflydb-dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2024-12-14 11:58:02 +00:00
Code Activity

fix(core): Auto cast doubles to ints in lua scripts (#922)

Browse source 
fix(core): Auto convert double to integers in lua scripts
This commit is contained in:
Vladislav 2023-03-08 19:51:01 +03:00 committed by GitHub
parent b7abe269f1
commit a37ccbfb28
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/core/interpreter.cc
View file

@ -84,13 +84,20 @@ void RedisTranslator::OnString(std::string_view str) {
ArrayPost();
}
// Doubles are not supported by Redis, however we can support them.
// Here is the use-case:
// local foo = redis.call('zscore', 'myzset', 'one')
// assert(type(foo) == "number")
void RedisTranslator::OnDouble(double d) {
static constexpr double kConvertEps = std::numeric_limits<double>::epsilon();
double fractpart, intpart;
fractpart = modf(d, &intpart);
ArrayPre();
lua_pushnumber(lua_, d);
// Convert to integer when possible to allow converting to string without trailing zeros.
if (abs(fractpart) < kConvertEps && intpart < std::numeric_limits<lua_Integer>::max() &&
intpart > std::numeric_limits<lua_Integer>::min())
lua_pushinteger(lua_, static_cast<lua_Integer>(d));
else
lua_pushnumber(lua_, d);
ArrayPost();
}

10
src/server/multi_test.cc
View file

@ -381,6 +381,16 @@ TEST_F(MultiTest, Eval) {
ASSERT_THAT(resp, ArrLen(3));
const auto& arr = resp.GetVec();
EXPECT_THAT(arr, ElementsAre("a", "b", "c"));
Run({"zadd", "z1", "123", "a", "12345678912345", "b", "12.5", "c"});
const char* kGetScore = "return redis.call('ZSCORE', KEYS[1], ARGV[1]) .. '-works'";
resp = Run({"eval", kGetScore, "1", "z1", "a"});
EXPECT_EQ(resp, "123-works");
resp = Run({"eval", kGetScore, "1", "z1", "b"});
EXPECT_EQ(resp, "12345678912345-works");
resp = Run({"eval", kGetScore, "1", "z1", "c"});
EXPECT_EQ(resp, "12.5-works");
}
TEST_F(MultiTest, Watch) {