mirrors/dragonflydb-dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2024-12-14 11:58:02 +00:00
Code Activity

fix(replica) : replica will not sync execution multi shard commands as default (#800)

Browse source 
-sfix(replica) : replica will not sync execution multi shard commands as default
This commit is contained in:
adiholden 2023-02-14 16:30:14 +02:00 committed by GitHub
parent c5e8a627b5
commit 72bad6c5ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.github/workflows/regression-tests.yml vendored
View file

@ -58,7 +58,8 @@ jobs:
run: |
cd ${GITHUB_WORKSPACE}/tests
export DRAGONFLY_PATH="${GITHUB_WORKSPACE}/build/dragonfly" # used by PyTests
pytest -xvs dragonfly/replication_test.py --df alsologtostderr --df vmodule=replica=2
pytest -xvs dragonfly/replication_test.py --df alsologtostderr --df vmodule=replica=2 --df enable_multi_shard_sync=true
pytest -xvs dragonfly/replication_test.py --df alsologtostderr --df vmodule=replica=2 --df enable_multi_shard_sync=false
- name: Send notification on failure
if: failure() || cancelled()

2
src/server/replica.cc
View file

@ -27,7 +27,7 @@ extern "C" {
#include "strings/human_readable.h"
#include "util/proactor_base.h"
ABSL_FLAG(bool, enable_multi_shard_sync, true,
ABSL_FLAG(bool, enable_multi_shard_sync, false,
"Execute multi shards commands on replica syncrhonized");
ABSL_DECLARE_FLAG(uint32_t, port);

2
src/server/transaction.cc
View file

@ -178,7 +178,7 @@ void Transaction::InitMultiData(KeyIndex key_index) {
}
void Transaction::StoreKeysInArgs(KeyIndex key_index, bool rev_mapping) {
DCHECK_EQ(key_index.bonus, 0);
DCHECK_EQ(key_index.bonus, 0U);
auto args = cmd_with_full_args_;