mirrors/dragonflydb-dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2024-12-15 17:51:06 +00:00
Code Activity

refactor(generic_family): Don't allocate StringSink on the heap (#2356)

Browse source 
refactor(generic_family): Don't allocate serializer on the heap
This commit is contained in:
Shahar Mike 2024-01-01 14:57:59 +02:00 committed by GitHub
parent 40f2a7190e
commit 069625f23f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/server/generic_family.cc
View file

@ -449,7 +449,7 @@ OpResult<std::string> OpDump(const OpArgs& op_args, string_view key) {
if (IsValid(it)) {
DVLOG(1) << "Dump: key '" << key << "' successfully found, going to dump it";
std::unique_ptr<::io::StringSink> sink = std::make_unique<::io::StringSink>();
io::StringSink sink;
int compression_mode = absl::GetFlag(FLAGS_compression_mode);
CompressionMode serializer_compression_mode =
compression_mode == 0 ? CompressionMode::NONE : CompressionMode::SINGLE_ENTRY;
@ -464,9 +464,9 @@ OpResult<std::string> OpDump(const OpArgs& op_args, string_view key) {
CHECK(!ec);
ec = serializer.SaveValue(it->second);
CHECK(!ec); // make sure that fully was successful
ec = serializer.FlushToSink(sink.get());
ec = serializer.FlushToSink(&sink);
CHECK(!ec); // make sure that fully was successful
std::string dump_payload(sink->str());
std::string dump_payload(sink.str());
AppendFooter(&dump_payload); // version and crc
CHECK_GT(dump_payload.size(), 10u);
return dump_payload;