From fb4cf5de79c0f740c9b3c23a2cf7974cc0c1267d Mon Sep 17 00:00:00 2001 From: postmannen Date: Wed, 22 Jun 2022 14:50:26 +0200 Subject: [PATCH] updated comments --- errorkernel.go | 4 ++-- requests.go | 1 - requests_test.go | 2 +- ringbuffer.go | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/errorkernel.go b/errorkernel.go index 47709e6..93bd6bc 100644 --- a/errorkernel.go +++ b/errorkernel.go @@ -199,9 +199,9 @@ const ( // errActionContinue is ment to be used when the a process // can just continue without taking any special care. errActionContinue errorAction = iota - // TODO: + // TODO NOT IMPLEMENTED YET: // errActionKill should log the error, - // stop the current worker process, and spawn a new. + // and f.ex. stop the current work, and restart from start? // errActionKill errorAction = iota ) diff --git a/requests.go b/requests.go index 25cd071..5ad377a 100644 --- a/requests.go +++ b/requests.go @@ -452,7 +452,6 @@ func newReplyMessage(proc process, message Message, outData []byte) { // Create a new message for the reply, and put it on the // ringbuffer to be published. - // TODO: Check that we still got all the fields present that are needed here. newMsg := Message{ ToNode: message.FromNode, // The ToNodes field is not needed since it is only a concept that exists when messages diff --git a/requests_test.go b/requests_test.go index 3286dc1..036fdeb 100644 --- a/requests_test.go +++ b/requests_test.go @@ -37,7 +37,7 @@ func TestMain(m *testing.M) { tstTempDir = os.TempDir() } - // TODO: Forcing this for now. + // NB: Forcing this for now. tstTempDir = "tmp" tstNats = newNatsServerForTesting(42222) diff --git a/ringbuffer.go b/ringbuffer.go index aa82ce2..1ed5d2a 100644 --- a/ringbuffer.go +++ b/ringbuffer.go @@ -300,7 +300,7 @@ func (r *ringBuffer) processBufferMessages(ctx context.Context, outCh chan samDB case <-delivredCh: // OK. case <-time.After(time.Second * 5): - // TODO: Check out if more logic should be made here if messages are stuck etc. + // TODO: Check if more logic should be made here if messages are stuck etc. // Testing with a timeout here to figure out if messages are stuck // waiting for done signal. log.Printf("Error: *** message %v seems to be stuck, did not receive delivered signal from reading process\n", v.ID)