From c9eb267f4e2c3f4ec5b17808dc911ed040f38730 Mon Sep 17 00:00:00 2001
From: postmannen <postmannen@gmail.com>
Date: Fri, 17 Sep 2021 10:28:48 +0200
Subject: [PATCH] sending error on not defined request types

---
 processes.go                   | 1 +
 read_socket_or_tcp_listener.go | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/processes.go b/processes.go
index 0cc2f71..0ef7104 100644
--- a/processes.go
+++ b/processes.go
@@ -185,6 +185,7 @@ func (s startup) pubREQHello(p process) {
 				sam, err := newSubjectAndMessage(m)
 				if err != nil {
 					// In theory the system should drop the message before it reaches here.
+					sendErrorLogMessage(proc.configuration, s.metrics, proc.toRingbufferCh, Node(proc.node), err)
 					log.Printf("error: ProcessesStart: %v\n", err)
 				}
 				proc.toRingbufferCh <- []subjectAndMessage{sam}
diff --git a/read_socket_or_tcp_listener.go b/read_socket_or_tcp_listener.go
index d07641f..62ea068 100644
--- a/read_socket_or_tcp_listener.go
+++ b/read_socket_or_tcp_listener.go
@@ -232,6 +232,7 @@ func (s *server) convertBytesToSAMs(b []byte) ([]subjectAndMessage, error) {
 	for _, m := range MsgSlice {
 		sm, err := newSubjectAndMessage(m)
 		if err != nil {
+			sendErrorLogMessage(s.configuration, s.metrics, s.newMessagesCh, Node(s.nodeName), err)
 			log.Printf("error: jsonFromFileData: %v\n", err)
 			continue
 		}
@@ -296,7 +297,7 @@ func newSubjectAndMessage(m Message) (subjectAndMessage, error) {
 
 	tmpH := mt.getHandler(m.Method)
 	if tmpH == nil {
-		return subjectAndMessage{}, fmt.Errorf("error: no such request type defined: %v", tmpH)
+		return subjectAndMessage{}, fmt.Errorf("error: no such request type defined: %v", m.Method)
 	}
 
 	sub := Subject{