mirrors/ctrl
1
0
Fork 0
mirror of https://github.com/postmannen/ctrl.git synced 2025-03-15 10:57:42 +00:00
Code Activity

removed fixed or no longer needed todo's

Browse source
This commit is contained in:
postmannen 2022-01-03 07:36:38 +01:00
parent e961111d96
commit 56cfd50e8b
4 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -931,7 +931,6 @@ Method Method `json:"method" yaml:"method"`
// Additional arguments that might be needed when executing the // Additional arguments that might be needed when executing the
// method. Can be f.ex. an ip address if it is a tcp sender, or the // method. Can be f.ex. an ip address if it is a tcp sender, or the
// shell command to execute in a cli session. // shell command to execute in a cli session.
// TODO:
MethodArgs []string `json:"methodArgs" yaml:"methodArgs"` MethodArgs []string `json:"methodArgs" yaml:"methodArgs"`
// ReplyMethod, is the method to use for the reply message. // ReplyMethod, is the method to use for the reply message.
// By default the reply method will be set to log to file, but // By default the reply method will be set to log to file, but
@ -940,7 +939,6 @@ ReplyMethod Method `json:"replyMethod" yaml:"replyMethod"`
// Additional arguments that might be needed when executing the reply // Additional arguments that might be needed when executing the reply
// method. Can be f.ex. an ip address if it is a tcp sender, or the // method. Can be f.ex. an ip address if it is a tcp sender, or the
// shell command to execute in a cli session. // shell command to execute in a cli session.
// TODO:
ReplyMethodArgs []string `json:"replyMethodArgs" yaml:"replyMethodArgs"` ReplyMethodArgs []string `json:"replyMethodArgs" yaml:"replyMethodArgs"`
// IsReply are used to tell that this is a reply message. By default // IsReply are used to tell that this is a reply message. By default
// the system sends the output of a request method back to the node // the system sends the output of a request method back to the node

2
message_and_subject.go
View file

@ -27,7 +27,6 @@ type Message struct {
// Additional arguments that might be needed when executing the // Additional arguments that might be needed when executing the
// method. Can be f.ex. an ip address if it is a tcp sender, or the // method. Can be f.ex. an ip address if it is a tcp sender, or the
// shell command to execute in a cli session. // shell command to execute in a cli session.
// TODO:
MethodArgs []string `json:"methodArgs" yaml:"methodArgs"` MethodArgs []string `json:"methodArgs" yaml:"methodArgs"`
// ReplyMethod, is the method to use for the reply message. // ReplyMethod, is the method to use for the reply message.
// By default the reply method will be set to log to file, but // By default the reply method will be set to log to file, but
@ -36,7 +35,6 @@ type Message struct {
// Additional arguments that might be needed when executing the reply // Additional arguments that might be needed when executing the reply
// method. Can be f.ex. an ip address if it is a tcp sender, or the // method. Can be f.ex. an ip address if it is a tcp sender, or the
// shell command to execute in a cli session. // shell command to execute in a cli session.
// TODO:
ReplyMethodArgs []string `json:"replyMethodArgs" yaml:"replyMethodArgs"` ReplyMethodArgs []string `json:"replyMethodArgs" yaml:"replyMethodArgs"`
// IsReply are used to tell that this is a reply message. By default // IsReply are used to tell that this is a reply message. By default
// the system sends the output of a request method back to the node // the system sends the output of a request method back to the node

3
process.go
View file

@ -643,9 +643,6 @@ func (p process) publishMessages(natsConn *nats.Conn) {
m.done <- struct{}{} m.done <- struct{}{}
// Increment the counter for the next message to be sent. // Increment the counter for the next message to be sent.
//
// TODO: Check if it is possible, or makes sense to move the
// counter out of the map.
p.messageID++ p.messageID++
{ {

3
requests.go
View file

@ -733,7 +733,6 @@ func (m methodREQCopyFileFrom) handler(proc process, message Message, node strin
dstFile := filepath.Base(DstFilePath) dstFile := filepath.Base(DstFilePath)
// Prepare for sending a new message with the output // Prepare for sending a new message with the output
// TODO: Maybe changing the type of Message.Data to []byte ?
// Copy the original message to get the defaults for timeouts etc, // Copy the original message to get the defaults for timeouts etc,
// and set new values for fields to change. // and set new values for fields to change.
@ -1605,7 +1604,7 @@ func (m methodREQToSocket) getKind() CommandOrEvent {
return m.commandOrEvent return m.commandOrEvent
} }
// TODO: // TODO: Not implemented.
// Handler to write to unix socket file. // Handler to write to unix socket file.
func (m methodREQToSocket) handler(proc process, message Message, node string) ([]byte, error) { func (m methodREQToSocket) handler(proc process, message Message, node string) ([]byte, error) {