mirrors/ctrl
1
0
Fork 0
mirror of https://github.com/postmannen/ctrl.git synced 2025-01-18 21:59:30 +00:00
Code Activity

bounds check for methodArgs

Browse source
This commit is contained in:
postmannen 2021-09-23 12:52:59 +02:00
parent 0fe32e7043
commit 3b106644e3
1 changed files with 57 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
requests.go
View file

@ -570,6 +570,14 @@ func (m methodREQOpProcessStart) handler(proc process, message Message, node str
// real method for the message. // real method for the message.
var mt Method var mt Method
switch {
case len(message.MethodArgs) < 1:
er := fmt.Errorf("error: methodREQOpProcessStart: got <1 number methodArgs")
sendErrorLogMessage(proc.configuration, proc.processes.metrics, proc.toRingbufferCh, proc.node, er)
log.Printf("%v\n", er)
return
}
m := message.MethodArgs[0] m := message.MethodArgs[0]
method := Method(m) method := Method(m)
tmpH := mt.getHandler(Method(method)) tmpH := mt.getHandler(Method(method))
@ -635,6 +643,15 @@ func (m methodREQOpProcessStop) handler(proc process, message Message, node stri
// that publisher processes are named by the node they are sending the // that publisher processes are named by the node they are sending the
// message to. Subscriber processes names are named by the node name // message to. Subscriber processes names are named by the node name
// they are running on. // they are running on.
switch {
case len(message.MethodArgs) != 4:
er := fmt.Errorf("error: methodREQCliCommand: got <4 number methodArgs, want: method,node,kind,id")
sendErrorLogMessage(proc.configuration, proc.processes.metrics, proc.toRingbufferCh, proc.node, er)
log.Printf("%v\n", er)
return
}
methodString := message.MethodArgs[0] methodString := message.MethodArgs[0]
node := message.MethodArgs[1] node := message.MethodArgs[1]
kind := message.MethodArgs[2] kind := message.MethodArgs[2]
@ -1069,8 +1086,19 @@ func (m methodREQCliCommand) handler(proc process, message Message, node string)
go func() { go func() {
defer proc.processes.wg.Done() defer proc.processes.wg.Done()
var a []string
switch {
case len(message.MethodArgs) < 1:
er := fmt.Errorf("error: methodREQCliCommand: got <1 number methodArgs")
sendErrorLogMessage(proc.configuration, proc.processes.metrics, proc.toRingbufferCh, proc.node, er)
log.Printf("%v\n", er)
return
case len(message.MethodArgs) >= 0:
a = message.MethodArgs[1:]
}
c := message.MethodArgs[0] c := message.MethodArgs[0]
a := message.MethodArgs[1:]
ctx, cancel := context.WithTimeout(proc.ctx, time.Second*time.Duration(message.MethodTimeout)) ctx, cancel := context.WithTimeout(proc.ctx, time.Second*time.Duration(message.MethodTimeout))
@ -1188,6 +1216,14 @@ func (m methodREQHttpGet) handler(proc process, message Message, node string) ([
go func() { go func() {
defer proc.processes.wg.Done() defer proc.processes.wg.Done()
switch {
case len(message.MethodArgs) < 1:
er := fmt.Errorf("error: methodREQHttpGet: got <1 number methodArgs")
sendErrorLogMessage(proc.configuration, proc.processes.metrics, proc.toRingbufferCh, proc.node, er)
log.Printf("%v\n", er)
return
}
url := message.MethodArgs[0] url := message.MethodArgs[0]
client := http.Client{ client := http.Client{
@ -1280,6 +1316,14 @@ func (m methodREQTailFile) handler(proc process, message Message, node string) (
go func() { go func() {
defer proc.processes.wg.Done() defer proc.processes.wg.Done()
switch {
case len(message.MethodArgs) < 1:
er := fmt.Errorf("error: methodREQTailFile: got <1 number methodArgs")
sendErrorLogMessage(proc.configuration, proc.processes.metrics, proc.toRingbufferCh, proc.node, er)
log.Printf("%v\n", er)
return
}
fp := message.MethodArgs[0] fp := message.MethodArgs[0]
var ctx context.Context var ctx context.Context
@ -1366,8 +1410,19 @@ func (m methodREQCliCommandCont) handler(proc process, message Message, node str
go func() { go func() {
defer proc.processes.wg.Done() defer proc.processes.wg.Done()
var a []string
switch {
case len(message.MethodArgs) < 1:
er := fmt.Errorf("error: methodREQCliCommand: got <1 number methodArgs")
sendErrorLogMessage(proc.configuration, proc.processes.metrics, proc.toRingbufferCh, proc.node, er)
log.Printf("%v\n", er)
return
case len(message.MethodArgs) >= 0:
a = message.MethodArgs[1:]
}
c := message.MethodArgs[0] c := message.MethodArgs[0]
a := message.MethodArgs[1:]
ctx, cancel := context.WithTimeout(proc.ctx, time.Second*time.Duration(message.MethodTimeout)) ctx, cancel := context.WithTimeout(proc.ctx, time.Second*time.Duration(message.MethodTimeout))