mirrors/ctrl
1
0
Fork 0
mirror of https://github.com/postmannen/ctrl.git synced 2025-01-05 20:09:16 +00:00
Code Activity

cleaned up todo's

Browse source
This commit is contained in:
postmannen 2022-04-20 07:13:47 +02:00
parent 7522bc203d
commit 242335c3bc
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
requests.go
View file

@ -2071,8 +2071,6 @@ func (m methodREQPublicKeysToNode) getKind() Event {
return m.event return m.event
} }
// TODO: Rename to :REQPublicKeysToNode
//
// Handler to put the public key replies received from a central server. // Handler to put the public key replies received from a central server.
func (m methodREQPublicKeysToNode) handler(proc process, message Message, node string) ([]byte, error) { func (m methodREQPublicKeysToNode) handler(proc process, message Message, node string) ([]byte, error) {
// Get a context with the timeout specified in message.MethodTimeout. // Get a context with the timeout specified in message.MethodTimeout.
@ -2081,8 +2079,6 @@ func (m methodREQPublicKeysToNode) handler(proc process, message Message, node s
// - Since this is implemented as a NACK message we could implement a // - Since this is implemented as a NACK message we could implement a
// metric thats shows the last time keys were updated. // metric thats shows the last time keys were updated.
// TODO: Define a subscriber for this Request type in startups.
ctx, _ := getContextForMethodTimeout(proc.ctx, message) ctx, _ := getContextForMethodTimeout(proc.ctx, message)
proc.processes.wg.Add(1) proc.processes.wg.Add(1)
@ -2093,7 +2089,7 @@ func (m methodREQPublicKeysToNode) handler(proc process, message Message, node s
go func() { go func() {
select { select {
case <-ctx.Done(): case <-ctx.Done():
// TODO: Should we receive a hash of he current keys from the node her ? // TODO: Should we receive a hash of he current keys from the node here ?
case outCh <- []byte{}: case outCh <- []byte{}:
} }
}() }()

2
steward_test.go
View file

@ -101,7 +101,7 @@ func TestStewardServer(t *testing.T) {
checkErrorKernelMalformedJSONtest, checkErrorKernelMalformedJSONtest,
checkMetricValuesTest, checkMetricValuesTest,
// TODO: checkREQRelay // checkREQRelay
} }
for _, f := range funcs { for _, f := range funcs {